Skip to content

test(packets): stop the clamp E2E racing the table re-render #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dborup merged 3 commits into from
Sep 20, 2026
Merged

test(packets): stop the clamp E2E racing the table re-render #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22933e8
test(packets): stop the clamp E2E racing the table re-render
Sep 20, 2026
49fee36
reviewfix(packets): name the real re-render trigger, drop committed s…
Sep 20, 2026
a924d8e
Merge origin/master into the clamp-fix branch
Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,6 @@ deploy-staging.sh

__pycache__/
*.pyc

# Playwright E2E screenshot output (written by test-issue-*-e2e.js)
e2e-screenshots/
13 changes: 12 additions & 1 deletion test-issue-1122-details-row-clamp-e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,19 @@ function measureRows() {
}, rows.filter(r => r.overflowing).map(r => r.hash));
assert(target, 'no overflowing channel-message row with decoded text found');
const row = page.locator(`#pktBody tr[data-hash="${target.hash}"]`).first();
await row.scrollIntoViewIfNeeded();
// Click a plain data cell (not the expand column, not a link).
// No separate scrollIntoViewIfNeeded(): the page re-renders #pktBody
// from under this step. The trigger measured in CI is the one-shot
// theme-refresh — app.js fetches /api/config/theme, dispatches
// theme-changed, debounces 300ms, and packets.js re-runs
// renderTableRows(), which resets _lastVisibleStart and clears
// tbody.innerHTML (observed: rows ready at +279ms, theme-refresh at
// +496ms, every row detached at +535ms). The background hop-resolution
// job re-renders the same way with unbounded latency.
// scrollIntoViewIfNeeded() resolves one element handle and does NOT
// re-resolve it, so a detach mid-action throws "Element is not attached
// to the DOM". click() scrolls as part of its actionability checks and
// re-resolves the selector on every retry, so it waits the row out.
await row.locator('td.col-time').click();
// The full text must be VISIBLE in a detail surface (never the table):
// desktop split pane, SlideOver (<=1023px) or the small-mobile bottom
Expand Down
Loading