added a few more features to qc#6
Open
davidedelvento wants to merge 55 commits intodbravender:masterfrom
Open
Conversation
… supplied seed. Printing the user supplied seed in case of failures
unless the exception is AssertionError.
make them pass - making it more pythonic (permission vs forgiveness)
implementation was going to recurse forever.
been created to hold them
a bug that caused repeated (infinite) recursion in some circumstances. This patch avoid it.
accordingly (added also a TODO item in README)
maximum recursion depth exceeded in the stack for too much recursion.
Improve the README.
Add Travis-CI support.
…qc, removing the explicit references to his repo (implicit references from github will stay)
…ssing away information possibly embedded into it
added 25 commits
September 19, 2014 13:50
…priately (and wasn't very useful to begin with), so removing
…t succeed instead of fail. Fixes issue #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE:
Dan,
I believe the current status of my repo now is good enough to be pulled. Please take your time to look at what I did (and possibly discuss it), but I'd appreciate if you give me acknowledgment about reading this message (since I am not sure if the new github notification strategy will notify you or if I should try to ping you in a different manner).
Thanks,
Davide
OLD MESSAGE:
Dan,
I forked your qc repo and I think made very nice improvements in functionality (even if they came from a very small number of lines of code). I think the current status is not yet "good enough" to be pulled, but I'm making the request anyway so if you have spare time during the weekend you could:
Cheers,
Davide