Add SP provider commands (Topic 11)#16
Conversation
Implement read-only `dcm sp provider list` and `dcm sp provider get` commands for querying service providers via the generated SP Manager client (`service-provider-manager/pkg/client`). Changes: - Add spec section 4.11 and test plan section 10a for SP provider commands - Implement list (with --type, --page-size, --page-token filters) and get - Add 12 Ginkgo test specs (TC-U139–TC-U147) covering all acceptance criteria - Register `provider` subcommand under `dcm sp` alongside `resource` - Table columns: ID, NAME, SERVICE TYPE, STATUS, HEALTH, CREATED Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
requested review from
ebichman-1,
gabriel-farache,
gciavarrini,
jenniferubah and
machacekondra
as code owners
gabriel-farache
left a comment
gabriel-farache
left a comment
There was a problem hiding this comment.
1 nitpick about REQ-SPP-020 as to how and where the "configured output format" is defined (then same comment on the matching AC and TC and tests)
Maybe it's already define somewhere else in the spec (for the REQ) but I still think the AC, TC and tests should mention the where and how.
Or maybe I misunderstood what "configured" implies here: for me, it means the user can specify a flag like -o yaml to have the output as yaml (or json or other)
| | ID | Requirement | Priority | Notes | | ||
| |----|-------------|----------|-------| | ||
| | REQ-SPP-010 | `dcm sp provider list` MUST list SP providers with optional `--type`, `--page-size`, `--page-token` flags | MUST | | | ||
| | REQ-SPP-020 | `dcm sp provider list` MUST display SP providers in the configured output format | MUST | | |
There was a problem hiding this comment.
in the configured output format
Is it format configured via optional flag? If that is the case, the flag must be listed in the previous REQ:
| REQ-SPP-010 |
dcm sp provider listMUST list SP providers with optional--type,--page-size,--page-tokenflags | MUST | |
There was a problem hiding this comment.
The same wording it used for all other commands. Output formatting has its own section: https://github.com/dcm-project/cli/blob/main/.ai/specs/dcm-cli.spec.md#43-output-formatting
4 participants
Implement read-only
dcm sp provider listanddcm sp provider getcommands for querying service providers via the generated SP Manager client (service-provider-manager/pkg/client).Changes:
providersubcommand underdcm spalongsideresource