Skip to content

Rename API gateway URL settings to control-plane#22

Merged
gciavarrini merged 10 commits into
dcm-project:mainfrom
gciavarrini:fix-api-var
Jun 19, 2026
Merged

Rename API gateway URL settings to control-plane#22
gciavarrini merged 10 commits into
dcm-project:mainfrom
gciavarrini:fix-api-var

Conversation

@gciavarrini

@gciavarrini gciavarrini commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Assisted-By: Claude (Anthropic)
Signed-off-by: Gloria Ciavarrini gciavarrini@redhat.com

@gciavarrini
Rename API gateway URL settings to control-plane.
25406a1 
Add control-plane-url flag, DCM_CONTROL_PLANE_URL, and :8080
default. Keep legacy api-gateway names as aliases.
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini gciavarrini mentioned this pull request Jun 12, 2026
Merged
gabriel-farache
gabriel-farache reviewed Jun 15, 2026
View reviewed changes

@gabriel-farache gabriel-farache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the .ai/specs were not updated with the change, could you either remove them or update them to avoid having discrepancies?

Note that if you remove the folder, the comment referencing them should also be deleted

Comment thread internal/config/config.go
Comment thread internal/config/config.go
Comment thread internal/config/config.go Outdated
Comment thread internal/config/config.go Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread internal/config/config_test.go Outdated
Comment thread internal/config/config.go Outdated
@gciavarrini
Import API clients from control-plane monorepo.
131cee8 
Drop catalog-manager, policy-manager, and service-provider-manager.
Pin control-plane at e4374fc25292.
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
Update docs for control-plane monolith and import paths.
4a3cb30 
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
update ai checkpoints
9cfa19d 
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
Remove legacy api-gateway aliases, wire URL via viper.
ca26527 
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
Sync docs and specs after api-gateway alias removal.
f98549b 
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
Revert loadConfig test helper to inline setup.
d39de16 
Assisted-By: Claude (Anthropic)
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini

gciavarrini commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

.ai

I totally forgot about them.
Updated in 4a3cb30 (specs + test-plans), 9cfa19d (checkpoints), f98549b (legacy alias cleanup in docs/specs).

@gabriel-farache

gabriel-farache commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

.ai

I totally forgot about them. Updated in 4a3cb30 (specs + test-plans), 9cfa19d (checkpoints), f98549b (legacy alias cleanup in docs/specs).

Thx.
I think the checkpoints are not really necessary at this point anymore as, AFAIK, they were used during the initial dev phase as a memory for the agent.
So we can keep them here but not alter them as they reflect the dev process

gabriel-farache
gabriel-farache reviewed Jun 18, 2026
View reviewed changes
Comment thread .ai/specs/dcm-cli.spec.md Outdated
| REQ-SPP-030 | `dcm sp provider get` MUST accept a `PROVIDER_ID` positional argument and display the SP provider | MUST | |
| REQ-SPP-040 | Missing `PROVIDER_ID` argument for `get` MUST result in a usage error (exit code 2) | MUST | |
| REQ-SPP-050 | All SP provider commands MUST use the generated SP Manager client (`service-provider-manager/pkg/client`) | MUST | |
| REQ-SPP-050 | All SP provider commands MUST use the generated SP provider client (`github.com/dcm-project/control-plane/pkg/sp/client/provider`) | MUST | |

@gabriel-farache gabriel-farache Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we are changing the name of SP Resource Manager to SP Provider?
I just want to make sure this is intentional

@gciavarrini gciavarrini Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Resource Manager is inside the SP Manager. Since it's in process I'm unsure TBH about the naming. I can revert it. WDYT?

@gabriel-farache gabriel-farache Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are using SPRM in a lot of places so changing the name in this PR, in this repo, for the first time does not seem right

@gciavarrini gciavarrini Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. See a0608dd

@gciavarrini

gciavarrini commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

.ai

I totally forgot about them. Updated in 4a3cb30 (specs + test-plans), 9cfa19d (checkpoints), f98549b (legacy alias cleanup in docs/specs).

Thx. I think the checkpoints are not really necessary at this point anymore as, AFAIK, they were used during the initial dev phase as a memory for the agent. So we can keep them here but not alter them as they reflect the dev process

Reverted 02e71f1

gabriel-farache
gabriel-farache reviewed Jun 18, 2026
View reviewed changes
Comment thread .ai/specs/dcm-cli.spec.md Outdated
@gabriel-farache

gabriel-farache commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@gciavarrini I think that once you cleaned the commit history you are good to merge :)

@gciavarrini
Revert "update ai checkpoints"
64e4ca3 
This reverts commit 9cfa19d.

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
Restore Manager client naming in ai spec
1bf2b04 
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini
Fix control-plane pkg links in docs and spec.
6a55a19 
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini gciavarrini merged commit 7b88b82 into dcm-project:main Jun 19, 2026
4 checks passed
@gciavarrini gciavarrini deleted the fix-api-var branch June 19, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriel-farache gabriel-farache gabriel-farache approved these changes

@machacekondra machacekondra machacekondra approved these changes

@jenniferubah jenniferubah jenniferubah approved these changes

@ygalblum ygalblum Awaiting requested review from ygalblum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gciavarrini @gabriel-farache @machacekondra @jenniferubah