Skip to content

Wire OpenAPI request validation on the monolith router #13

Merged
gciavarrini merged 3 commits into
dcm-project:mainfrom
gciavarrini:wire-oapi-request-validation
Jun 19, 2026
Merged

Wire OpenAPI request validation on the monolith router #13
gciavarrini merged 3 commits into
dcm-project:mainfrom
gciavarrini:wire-oapi-request-validation

Conversation

@gciavarrini

Copy link
Copy Markdown
Contributor

Restores OpenAPI request validation on the unified chi router in internal/app, matching what the standalone per-domain apiservers did before removal in 7985ea8.

  • Load catalog, policy, SP provider, and SP RM specs via GetSpec()
  • Dispatch OapiRequestValidatorWithOptions by path prefix on /api/v1alpha1
  • Skip validation for the monolith-only health endpoint
  • Add Ginkgo coverage for health bypass and malformed JSON on all four HTTP domains

Placement and policy evaluation remain in-process only; no new public routes.

Fixes: FLPATH-4381

--
Assisted-By: Claude (Anthropic)
Signed-off-by: Gloria Ciavarrini gciavarrini@redhat.com

Dispatch per-domain OapiRequestValidator on /api/v1alpha1 routes.
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Cover health bypass and malformed JSON on all four HTTP domains.
Assisted-By: Claude (Anthropic)

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini gciavarrini merged commit 2f6f72d into dcm-project:main Jun 19, 2026
3 checks passed
@gciavarrini gciavarrini deleted the wire-oapi-request-validation branch June 19, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants