Run control-plane container as non-root#16
Open
gciavarrini wants to merge 1 commit into
Open
Conversation
gciavarrini
requested review from
gabriel-farache,
jenniferubah and
machacekondra
as code owners
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Match the old policy-manager image now that managers share one binary. Add Helm securityContext for cluster deploys. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
control-plane-non-root-user
branch
from
36cebeb to
4ee947e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monolith image still ran as root because the runtime Containerfile never set a
USER.That came from the old catalog/placement/SP images, not from anything control-plane actually needs.
policy-manageralready usedUSER 1001.Since all manager logic now lives in one binary, this PR standardises on that approach.
Why
Control-plane only listens on :8080 and talks to Postgres/NATS over the network. It does not need root. This is mainly packaging consistency for the monolith, with a small security benefit and better alignment with restricted Kubernetes/OpenShift policies.
Changes
UID 10010Fixes
FLPATH-4382
--
Assisted-By: Claude (Anthropic)
Signed off-by: Gloria Ciavarrini gciavarrini@redhat.com