Test status reader in SPRM#21
Merged
testetson22 merged 7 commits intoJun 18, 2026
Merged
Conversation
Verify the SPRM's NATS status consumer propagates status updates to the gateway API. Covers happy-path RUNNING propagation, error status for bad images (PENDING from ImagePullBackOff), independent status tracking across concurrent instances, and status visibility in both GET and list endpoints. Signed-off-by: Thomas Stetson <tstetson@redhat.com>
Tests were failing with 424 (Failed Dependency) on fresh deployments because no routing policy existed. Each test context now creates and cleans up its own policy, making the tests fully self-contained. Signed-off-by: Thomas Stetson <tstetson@redhat.com>
Publish fake instance IDs and malformed payloads directly to NATS and verify the SPRM consumer stays healthy. Add status stability check and confirm deleted instances return 404 with no ghost records. Signed-off-by: Thomas Stetson <tstetson@redhat.com>
Signed-off-by: Thomas Stetson <tstetson@redhat.com>
testetson22
requested review from
chadcrum,
ddmitrie,
gabriel-farache,
gciavarrini,
hardengl,
jenniferubah,
machacekondra,
pkliczewski,
y-first and
ygalblum
as code owners
Signed-off-by: Thomas Stetson <tstetson@redhat.com>
…ency - Replace static sleep with Eventually and Consistently checks to improve test reliability for health endpoint and status preservation. - Clarify test descriptions for ordered delivery within a single NATS publisher connection. Signed-off-by: Thomas Stetson <tstetson@redhat.com>
Replace time.Sleep calls with Eventually/Consistently matchers to eliminate flakiness, add defer resp.Body.Close() to prevent FD leaks on assertion failures, and use explicit boolean flag for deletion tracking. Add code quality patterns to .cursor/rules/e2e-tests.mdc. Signed-off-by: Thomas Stetson <tstetson@redhat.com>
y-first
approved these changes
Jun 17, 2026
chadcrum
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time.SleepwithEventually/Consistentlymatchers, close response bodies in allItblocks, use explicitinstanceDeletedflag, and add NATS ordering clarification comment.cursor/rules/e2e-tests.mdccodifying the review fixes as project conventionsTest plan
--ginkgo.focus="Status Reader")go build -tags e2eandgo vet -tags e2ecleantime.Sleepin the test fileapi_instances_test.gorouting policy issue on fresh deploys)