fix(tests): add Label("cluster") to rehydration tests with K8s assertions#25
Merged
chadcrum merged 1 commit intoJun 18, 2026
Merged
Conversation
…ions
Tests using inline `if kubectlAvailable` guards to assert K8s resource
state were missing Label("cluster"), causing failures in CI when running
against a mock backend on a reachable cluster. The guard is always true
in that environment since kubectlAvailable checks cluster reachability
and provider namespaces are hardcoded non-empty.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Chad Crum <chadcrum@users.noreply.github.com>
chadcrum
requested review from
ddmitrie,
gabriel-farache,
gciavarrini,
hardengl,
jenniferubah,
machacekondra,
pkliczewski,
testetson22 and
y-first
as code owners
y-first
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Label("cluster")to 5 rehydrationIt()blocks that contain inlineif kubectlAvailableK8s assertions but were missing the labelrehydration_policy_test.go:148("policy change causes rehydration to select different provider") — no secondary protection (disruptive/requirePodman), actively fails in CI against mock backend on a reachable clusterrehydration_policy_test.goandrehydration_failover_test.goare hardened for consistency (already protected bydisruptive+requirePodman)Test plan
--label-filter 'rehydration && !cluster'— previously failing policy test is now correctly excludedclusterlabel is included🤖 Generated with Claude Code