Skip to content

rest: extract elements instead of matching#199

Open
jkoelker wants to merge 1 commit into
dcos:masterfrom
jkoelker:fix_backend_rest
Open

rest: extract elements instead of matching#199
jkoelker wants to merge 1 commit into
dcos:masterfrom
jkoelker:fix_backend_rest

Conversation

@jkoelker
Copy link
Copy Markdown
Contributor

@jkoelker jkoelker commented Aug 21, 2020

If the host has old style VIPs, then the matching will fail, instead
just extract the first two elements regardless of the length.

dcos/dcos#7568

If the host has old style VIPs, then the matching will fail, instead
just extract the first two elements regardless of the length.
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.05%. Comparing base (d35033b) to head (63cc66a).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   66.02%   66.05%   +0.02%     
==========================================
  Files          55       55              
  Lines        3759     3759              
==========================================
+ Hits         2482     2483       +1     
+ Misses       1277     1276       -1     
Flag Coverage Δ
ct 34.66% <ø> (ø)
ct2 46.02% <ø> (+0.02%) ⬆️
eunit 24.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/dcos_rest/src/dcos_rest_vips_handler.erl 45.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35033b...63cc66a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant