Repository navigation
Port to omp 18.3 SDK (settings registry, namespaced AuthStorage, pi-tui moves) - #94
Merged
Merged
Conversation
…, pi-tui moves) omp 18.2 replaced the path-keyed Settings API with typed registry handles, namespaced AuthStorage (credentials/keys/oauth) and moved theme, thinking and goal-tool modules to @oh-my-pi/pi-tui. lib/omp-settings.ts is the single path->handle adapter. Also guards NO_PROXY for loopback: Bun 1.4 proxies loopback requests, which broke local providers behind HTTP_PROXY. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports omp-web to
@oh-my-pi/* ~18.3.2. omp 18.2 replaced the path-keyed Settings API with typed registry handles, namespacedAuthStorage(credentials/keys/oauth), and moved theme/thinking/goal-tool modules to@oh-my-pi/pi-tui.lib/omp-settings.tsis the single path→handle adapter so the rest of the codebase doesn't scatter registry calls.NO_PROXYfor loopback: Bun 1.4 proxies loopback requests, which broke local providers behindHTTP_PROXY.Unblocks the stalled
automation/omp-18.xdraft PRs (#77–#93), which all fail typecheck/tests on 18.x; this branch passestsc --noEmitandbun test(534 pass / 1 skipped) on 18.3.2.Test
bun run typecheckclean,bun test534/535,bun run lintclean on the branch.Disclosure
AI-assisted port (Claude Opus 5.5) authored and verified in a live deployment; the same port already ships in the fork's
0.5.xreleases.Co-Authored-By: Claude Opus 5.5 (1M context) noreply@anthropic.com