Skip to content

fixed bug on SalesforceParamConverter declaration #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jury89 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug on SalesforceParamConverter declaration #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Request/ParamConverter/SalesforceParamConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

namespace Ddeboer\Salesforce\MapperBundle\Request\ParamConverter;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Request\ParamConverter\ParamConverterInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ConfigurationInterface;
use Ddeboer\Salesforce\MapperBundle\Mapper;

/**
Expand Down Expand Up @@ -40,7 +40,7 @@ public function __construct(Mapper $mapper, array $mappings)
/**
* {@inheritdoc}
*/
public function apply(Request $request, ConfigurationInterface $configuration)
public function apply(Request $request, ParamConverter $configuration)
{
// @todo Is it smart to do this based on variable name? Perhaps it's
// better to, here also, look at class name?
Expand All @@ -63,9 +63,8 @@ public function apply(Request $request, ConfigurationInterface $configuration)
/**
* {@inheritdoc}
*/
public function supports(ConfigurationInterface $configuration)
public function supports(ParamConverter $configuration)
{
return in_array($configuration->getClass(), $this->mappings);
}
}