fix: correct file detection and skill check in code-review#104
Merged
Conversation
- Disambiguate TypeScript vs React file conditions to prevent LLM conflation (.ts/.tsx was being misread as .tsx/.jsx) - Switch skill availability check from Glob to Read (Glob doesn't expand ~ but Read does, causing false "not installed" for all optional language skills)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ts/.tsxwas too similar to.tsx/.jsx, causing the orchestrating LLM to conflate them and miss plain.tsfiles~to the home directory, causing all optional language skills to incorrectly report as "not installed"Root Cause
Two independent bugs combined:
.ts/.tsx(TypeScript) adjacent to.tsx/.jsx(React). The orchestrating agent misread the TypeScript condition as.tsx/.jsx, skipping TypeScript review when only plain.tsfiles changed.Glob("~/.claude/skills/{focus}/SKILL.md")returns no results because Glob doesn't expand~. TheReadtool does expand~, so switching to Read fixes skill detection on all platforms.Test plan
/code-reviewon a branch with only.tsfile changes — TypeScript review should trigger/code-reviewon a branch with.tsxchanges — both TypeScript and React reviews should trigger