Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion docs/reference/skills-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Create in `shared/skills/skill-name/SKILL.md` (~120-150 lines):
```markdown
---
name: skill-name
description: Brief description with trigger phrases (<180 chars)
description: "This skill should be used when..." with concrete trigger words (<180 chars)
user-invocable: false
allowed-tools: Read, Grep, Glob, AskUserQuestion
activation:
Expand Down Expand Up @@ -140,6 +140,24 @@ For additional examples and detection patterns:
- [ ] Checklist item 2
```

## Description Rules

Skill descriptions appear in Claude Code's skill catalog and influence when Claude auto-invokes skills. Poorly written descriptions can cause Claude to treat the description itself as instructions, bypassing the actual SKILL.md flowchart.

**Format**: Descriptions MUST start with `"This skill should be used when..."`.

**Include**: Concrete trigger words -- tool names, error types, user phrases, file types, or review focus areas that signal when the skill is relevant.

**Never**: Describe the skill's internal process, steps, methodology, or output format in the description. That information belongs in the SKILL.md body, not the frontmatter.

### Examples

| Bad (process summary) | Good (trigger-only) |
|---|---|
| "Standard review methodology providing the 6-step process and 3-category issue classification used by all review agents." | "This skill should be used when performing a code review to apply the standard 6-step review process." |
| "Security vulnerability analysis patterns for code review. Detects injection flaws, authentication bypasses, insecure cryptography." | "This skill should be used when reviewing code for injection flaws, auth bypasses, or hardcoded secrets." |
| "Enforce RED-GREEN-REFACTOR cycle during implementation. Write failing tests before production code." | "This skill should be used when implementing new features, fixing bugs, or writing new code. Enforces RED-GREEN-REFACTOR." |

## Progressive Disclosure Structure

```
Expand Down
2 changes: 1 addition & 1 deletion plugins/devflow-implement/skills/self-review/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: self-review
description: Self-review framework evaluating implementation quality against 9 pillars (correctness, completeness, security, performance, maintainability, testing, documentation, error handling, simplicity). Fixes P0/P1 issues immediately rather than reporting them. Used by the Scrutinizer agent as a quality gate.
description: This skill should be used when evaluating implementation quality before submission, checking correctness, security, and simplicity.
user-invocable: false
allowed-tools: Read, Grep, Glob, Edit, Write, Bash
---
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: security-patterns
description: Security vulnerability analysis patterns for code review. Detects injection flaws, authentication bypasses, insecure cryptography, hardcoded secrets, and missing input sanitization. Loaded by Reviewer agent when focus=security.
description: This skill should be used when reviewing code for injection flaws, auth bypasses, or hardcoded secrets.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/architecture-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: architecture-patterns
description: Architecture analysis patterns for code review. Detects SOLID violations, tight coupling, layering issues, and dependency direction problems. Loaded by Reviewer agent when focus=architecture.
description: This skill should be used when reviewing code for SOLID violations, tight coupling, or layering issues.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/complexity-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: complexity-patterns
description: Complexity analysis patterns for code review. Detects high cyclomatic complexity, deep nesting, long functions, and readability issues that hinder maintainability. Loaded by Reviewer agent when focus=complexity.
description: This skill should be used when reviewing code for high cyclomatic complexity, deep nesting, or long functions.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/consistency-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: consistency-patterns
description: Consistency analysis patterns for code review. Detects naming convention violations, pattern deviations, unnecessary simplification, and feature truncation in diffs. Loaded by Reviewer agent when focus=consistency.
description: This skill should be used when reviewing code for naming convention violations, pattern deviations, or inconsistent API styles.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/database-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: database-patterns
description: Database analysis patterns for code review. Detects missing indexes, slow queries, unsafe migrations, schema design issues, and connection pool misuse. Loaded by Reviewer agent when focus=database.
description: This skill should be used when reviewing database queries, migrations, indexes, or schema changes.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/dependencies-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: dependencies-patterns
description: Dependency analysis patterns for code review. Detects known CVEs, outdated packages, license incompatibilities, and unnecessary transitive dependencies. Loaded by Reviewer agent when focus=dependencies.
description: This skill should be used when reviewing dependency changes, lock files, or package additions.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/documentation-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: documentation-patterns
description: Documentation analysis patterns for code review. Detects doc drift from code changes, missing documentation for public APIs, stale comments, and misleading README sections. Loaded by Reviewer agent when focus=documentation.
description: This skill should be used when reviewing for documentation drift, missing API docs, or stale comments.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/performance-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: performance-patterns
description: Performance analysis patterns for code review. Detects N+1 queries, memory leaks, unbounded allocations, I/O bottlenecks, and missing caching opportunities. Loaded by Reviewer agent when focus=performance.
description: This skill should be used when reviewing code for N+1 queries, memory leaks, or I/O bottlenecks.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/regression-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: regression-patterns
description: Regression analysis patterns for code review. Detects lost functionality, removed exports, changed signatures, and behavioral changes that break existing consumers. Loaded by Reviewer agent when focus=regression.
description: This skill should be used when reviewing changes that may remove exports, change signatures, or alter behavior.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/review-methodology/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: review-methodology
description: Standard review methodology providing the 6-step process and 3-category issue classification (must-fix, should-fix, nit) used by all DevFlow review agents. Ensures consistent, fair, and actionable code reviews across all focus areas. Loaded by the unified Reviewer agent.
description: This skill should be used when performing a code review to apply the standard 6-step review process.
user-invocable: false
allowed-tools: Read, Grep, Glob, Bash
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/security-patterns/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: security-patterns
description: Security vulnerability analysis patterns for code review. Detects injection flaws, authentication bypasses, insecure cryptography, hardcoded secrets, and missing input sanitization. Loaded by Reviewer agent when focus=security.
description: This skill should be used when reviewing code for injection flaws, auth bypasses, or hardcoded secrets.
user-invocable: false
allowed-tools: Read, Grep, Glob
---
Expand Down
2 changes: 1 addition & 1 deletion shared/skills/self-review/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: self-review
description: Self-review framework evaluating implementation quality against 9 pillars (correctness, completeness, security, performance, maintainability, testing, documentation, error handling, simplicity). Fixes P0/P1 issues immediately rather than reporting them. Used by the Scrutinizer agent as a quality gate.
description: This skill should be used when evaluating implementation quality before submission, checking correctness, security, and simplicity.
user-invocable: false
allowed-tools: Read, Grep, Glob, Edit, Write, Bash
---
Expand Down
5 changes: 1 addition & 4 deletions shared/skills/test-driven-development/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
---
name: test-driven-development
description: >-
Enforce RED-GREEN-REFACTOR cycle during implementation. Write failing tests before
production code. Distinct from test-patterns (which reviews test quality) — this
skill enforces the TDD workflow during code generation.
description: This skill should be used when implementing new features, fixing bugs, or writing new code. Enforces RED-GREEN-REFACTOR.
user-invocable: false
allowed-tools: Read, Grep, Glob
activation:
Expand Down