test: add coverage for installManagedSettings#97
Merged
Conversation
Add 6 tests covering installManagedSettings paths: - Unsupported platform (getManagedSettingsPath throws) - Template read failure - Direct write success - Merge with existing managed settings (preserves entries) - EACCES + non-TTY returns false - Non-EACCES write errors return false Update CHANGELOG [Unreleased] with sudo trust prompt and test coverage entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installManagedSettings()covering all testable code paths (unsupported platform, template read failure, direct write, merge with existing settings, EACCES non-TTY, non-EACCES errors)[Unreleased]with sudo trust prompt (chore: add sudo trust prompt before managed settings write #96) and test coverage entriesTest plan
npm test— all 191 tests pass (was 185)