test(engines): parametrize wire-protocol tests across all sidecar engines - #1408
Merged
debpalash merged 2 commits intoAug 7, 2026
Conversation
…ines Every sidecar (9 modules: TTS + ASR + echo) carries its own copy of the length-prefixed JSON wire protocol. This parametrizes the 4 protocol invariants (send/recv roundtrip, EOF, oversized-frame cap, truncated-body) across all of them, so a bug in any sidecar's copy is caught. Inspired by debpalash's test_pockettts_sidecar.py (PR #1) which established the pattern for a single sidecar; this lifts the generic protocol tests so every sidecar inherits the same coverage. 36 test cases, 0.6s.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request adds shared parametrized tests for subprocess sidecar wire protocols. The tests cover round trips, clean EOF, oversized frames, and truncated bodies across sidecar modules. ChangesSubprocess sidecar wire protocol
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 8 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (8 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
debpalash
added a commit
that referenced
this pull request
Aug 7, 2026
The PR merged without an Unreleased entry. It is not user-facing, so it belongs under CI rather than Fixed — but the contributor credit the repo keeps for community work should still be there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every sidecar (9 modules) carries its own copy of the length-prefixed JSON wire protocol. This parametrizes the 4 protocol invariants across all of them so a bug in any copy is caught.
Inspired by @debpalash's test_pockettts_sidecar.py (PR paoloantinori#1), which established the pattern for a single sidecar. This lifts the generic protocol tests (send/recv roundtrip, EOF, oversized-frame cap, truncated-body) so every sidecar inherits the same coverage. Engine-specific tests (language, PCM, voice cache) stay in each engine's own file.
36 test cases, 0.6s, no deps (all sidecar modules are stdlib-only at import time).
Adds 36 parametrized wire-protocol tests for all nine sidecar engines. The tests verify round trips, EOF handling, oversized-frame rejection, and truncated-body errors. The change is test-only and adds no dependencies or production behavior.