Repository navigation
feat(decdn_node): expose slash-appeal + scan-floor config knobs (ADR 028) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,12 @@ eth_keystore = "{{ decdn_keystore_file }}" | |
| payment_channel_address = "{{ decdn_payment_channel_address }}" | ||
| capacity_bond_address = "{{ decdn_capacity_bond_address }}" | ||
| slash_judge_address = "{{ decdn_slash_judge_address }}" | ||
| {% if decdn_slash_appeal_address | length > 0 %} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Following the general rules, use References
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not adopting this one. The StrictUndefined failure mode does not apply here: this repo uses Ansible's default undefined handling (no StrictUndefined in ansible.cfg), and |
||
| slash_appeal_address = "{{ decdn_slash_appeal_address }}" | ||
| {% endif %} | ||
| {% if decdn_slash_judge_from_block | int > 0 %} | ||
| slash_judge_from_block = {{ decdn_slash_judge_from_block | int }} | ||
| {% endif %} | ||
|
Copilot marked this conversation as resolved.
|
||
|
|
||
| [payment] | ||
| rate_per_mb = {{ decdn_rate_per_mb }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed via the
| intrender fix (495bf93) rather than tightening the regex. Once the value is emitted through| int, a leading-zero input normalizes to the mathematically-identical block number (001->1) and always produces valid TOML, so the invalid-config path this flags can no longer occur. Keeping the regex as^[0-9]+$deliberately: rejecting001would fail loud on a harmless, value-preserving form, whereas normalizing it is friendlier and safe. The regex still catches genuine typos (letters, negatives, floats).