Repository navigation
ci(scripts): drop bump_decdn's changelog step now every artifact is released - #151
Merged
Merged
Conversation
…eleased The `scripts` job failed on main after the first releases: the Changelog tests in scripts/tests/test_bump_decdn.py copy the real collection changelogs and expected an [Unreleased] section, which the release commits turned into dated 0.1.0 sections. `bump_decdn.py changelog` only ever wrote an entry under [Unreleased], until each collection's first release; release.sh writes every later section from the PR titles. Both collections and the chart are released, so the step can never write again. Remove the subcommand, its tests, its call in open-decdn-bump.sh and the checklist text in the decdn_node and sponsord READMEs. test_leaves_the_changelogs stays, with its own list of the three changelogs (now the chart's too), and also plants the image digest, so rewrite's CHANGELOG.md exclusion is checked for both digests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The obsolete path is removed consistently across implementation, caller, tests, and documentation.
0 open findings
What changed in this PR
Removes obsolete pre-release changelog handling now that all artifacts use release-generated changelogs.
Changes:
- Removes the
changelogcommand and invocation. - Updates tests to ensure pin rewrites leave all changelogs untouched.
- Updates release-bump documentation.
| File | Description |
|---|---|
scripts/bump_decdn.py |
Removes changelog mutation support. |
scripts/open-decdn-bump.sh |
Stops invoking changelog updates. |
scripts/tests/test_bump_decdn.py |
Removes obsolete tests and strengthens changelog preservation coverage. |
ansible/roles/decdn_node/README.md |
Updates the bump checklist. |
ansible/roles/sponsord/README.md |
Removes first-release instructions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
scriptsjob failed on main after the first releases (node-collection-v0.1.0,publisher-collection-v0.1.0,decdn-node-0.1.3). Three tests inscripts/tests/test_bump_decdn.py(theChangelogclass) copy the real collection changelogs and expect an## [Unreleased]section; the release commits turned those into dated## [0.1.0]sections.bump_decdn.py changelogonly wrote a bump entry under[Unreleased], until each collection's first release (its own comment says so).release.shwrites every later section from PR titles. Every artifact is now released, so the step can never write again: removing it, not faking a fixture for dead code.What
scripts/bump_decdn.py: drop thechangelogsubcommand,CHANGELOGSandchangelog().scripts/tests/test_bump_decdn.py: drop theChangelogtests. Keeptest_leaves_the_changelogs(rewritemust not touch a changelog) with a test-local list of the three changelogs, now the chart's too, and plant the image digest as well as the sums digest.scripts/open-decdn-bump.sh: drop thebump changelogcall.decdn_nodeandsponsordREADMEs: drop the bump checklist's[Unreleased]entry text.citype so the title stays out of the collection changelogs (cliff.tomlskips it): nothing here changes what an operator runs.Checks
make test-scriptspasses (only theUPSTREAMgenerators skipped).bump_decdnunit tests: 18 OK. With theCHANGELOG.mdfilter removed fromtracked_files,test_leaves_the_changelogsfails and nothing else does.pre-commitclean on the changed files.🤖 Generated with Claude Code