fix(molecule): sync stub key-gen to --keystore-password-file - #46
Merged
Merged
Conversation
Commit #45 renamed the role's key-gen flag from --password-file to --keystore-password-file but left the Molecule stub's key_gen() parsing the old flag, so the generate-keystore scenario's converge fails with "stub key-gen: --output-dir and --password-file are required" and the Molecule workflow is red on main. Point the stub at --keystore-password-file (and update the two doc comments) to match the role's real invocation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, stub-only, and brings Molecule’s stub CLI contract back into alignment with the role’s current key-gen invocation without impacting production deployments.
Pull request overview
This PR fixes the Molecule generate-keystore scenario by syncing the Molecule decdn stub’s key-gen argument parsing and related documentation to the renamed CLI flag --keystore-password-file, matching the role’s real invocation and restoring the Molecule workflow gate to green.
Changes:
- Update the Molecule stub
key-genimplementation to read--keystore-password-fileinstead of the removed--password-file. - Update the stub’s
key-gencontract documentation and its “required args” error message to reference--keystore-password-file.
File summaries
| File | Description |
|---|---|
| ansible/molecule/default/files/decdn-node-stub | Aligns stub key-gen flag parsing and docs with the role’s --keystore-password-file invocation to fix Molecule converge. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the red Molecule workflow on
main.Why
Commit #45 (
fae0591, "key-gen flag is--keystore-password-fileon main") renamed the role's key-gen flag from--password-fileto--keystore-password-fileinroles/decdn_node/tasks/main.yml, but the Molecule stub binary'skey_gen()still parsed the old--password-file. Thegenerate-keystorescenario's converge therefore fails:(failing run)
This is a stub-only mismatch — real deploys are unaffected — but it keeps the Molecule gate red.
Change
Point the stub's
key_gen()at--keystore-password-file, matching the role's real invocation, and update the two doc comments that still referenced the old flag. Stub-only; no role or protocol change.🤖 Generated with Claude Code