chore(chart): re-vendor upstream dashboards @ bdba9e60 - #71
Merged
Merged
Conversation
Upstream bdba9e60 metered a new serve-loop fault (decdn_serve_stream_proof_budget_exhausted_total). The delivery dashboard gains a panel query for it, and both dashboards' 'unattributed failures' panel now subtracts 23 reason counters instead of 22. Alert rules and the other two dashboards are unchanged. Caught by the first upstream-drift run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are consistent with the upstream update, with no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Re-vendors monitoring dashboards from upstream commit bdba9e60, adding proof-budget exhaustion visibility.
Changes:
- Adds the new proof-budget metric query.
- Updates failure attribution calculations.
- Refreshes source metadata and hashes.
| File | Reviewed change |
|---|---|
charts/decdn-node/files/monitoring/SOURCE |
Updates upstream provenance and hashes. |
charts/decdn-node/files/monitoring/grafana-dashboard.json |
Updates failure attribution. |
charts/decdn-node/files/monitoring/dashboard-delivery.json |
Adds the metric query and updates attribution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first
upstream-driftrun after #69 failed with the monitoring mirror stale, which is what it's for.Upstream
bdba9e60added a new serve-loop fault metric,decdn_serve_stream_proof_budget_exhausted_total. Changes fromscripts/sync-monitoring.sh ../decdn:dashboard-delivery.json: a new query ("stopped mid-stream: proof budget exhausted").grafana-dashboard.json.SOURCEis updated. The alert rules and the other dashboards are unchanged.Network profiles and config schema keys are current against the same upstream commit.
Test plan
scripts/sync-monitoring.sh ../decdn --check→ currentmake lint-helm(one ConfigMap per vendored dashboard, valid JSON with a uid)🤖 Generated with Claude Code