chore: sync upstream decdn/decdn @ 3ebf5f17 - #80
Merged
Merged
Conversation
Re-sync the upstream mirrors and wire the one new config key. - charts/decdn-node/files/monitoring: re-vendored (new DecdnChainWatcherFlapping alert, probe latency/TTFB and eth_getLogs span panels). - schema-keys.txt: regenerated (155 -> 156 paths); the tracked ref in gen-schema-keys.py and the role README moves d3bc7da7 -> 3ebf5f17. - decdn_node: new decdn_get_logs_max_block_span knob, rendered as blockchain.get_logs_max_block_span (#2152), >= 1 when set, following decdn_fee_shares_poll_interval_sec through defaults, template, the shape and strictly-positive asserts, README, schema converge and the chart's ci-values. - molecule/validation: range-min1 case, the first negative test of the ">= 1 when set" assert. - molecule/schema/verify.yml: the key-count comment now matches the render (130, slack 5). networks.yml was already current. IPv6 bind (#2144) and the watchdog heartbeat (#2145) were already covered; the other upstream commits need no devops change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad upstream and vendored-asset sync, incomplete full test run, and missing chart changelog entry warrant human review.
Review effort: Lite
Findings: None
What changed in this PR
Syncs deployment configuration, schema metadata, and monitoring assets with upstream decdn/decdn commit 3ebf5f17.
Changes:
- Adds and validates
decdn_get_logs_max_block_span. - Refreshes monitoring dashboards and alerts.
- Updates schema tracking, documentation, changelogs, and test fixtures.
| File | Summary |
|---|---|
charts/decdn-node/files/monitoring/SOURCE |
Updates upstream source metadata. |
charts/decdn-node/files/monitoring/prometheus-alerts.yml |
Adds watcher alerts. |
charts/decdn-node/files/monitoring/grafana-dashboard.json |
Updates watcher visualizations. |
charts/decdn-node/files/monitoring/dashboard-node.json |
Adds probe latency panels. |
charts/decdn-node/files/monitoring/dashboard-delivery.json |
Adds first-byte latency panels. |
charts/decdn-node/files/monitoring/dashboard-chain.json |
Adds eth_getLogs monitoring. |
charts/decdn-node/ci/ci-values.yaml |
Exercises the new configuration key. |
ansible/roles/decdn_node/templates/node.toml.j2 |
Renders the new setting. |
ansible/roles/decdn_node/tasks/main.yml |
Validates the setting. |
ansible/roles/decdn_node/README.md |
Documents configuration and tuning. |
ansible/roles/decdn_node/defaults/main.yml |
Defines the default. |
ansible/molecule/validation/converge.yml |
Adds minimum-value validation. |
ansible/molecule/schema/verify.yml |
Updates schema expectations. |
ansible/molecule/schema/files/schema-keys.txt |
Adds the schema path. |
ansible/molecule/schema/files/gen-schema-keys.py |
Updates the tracked revision. |
ansible/molecule/schema/converge.yml |
Exercises schema rendering. |
ansible/galaxy/CHANGELOG.md |
Documents the role change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the repo to upstream
decdn/decdn@3ebf5f17(15 commits, #2138–#2152) and wires the one new config key.charts/decdn-node/files/monitoring/re-vendored withscripts/sync-monitoring.sh. It adds theDecdnChainWatcherFlappingalert, probe latency and time-to-first-byte panels, and theeth_getLogswindow-span panel.schema-keys.txtregenerated (155 → 156 paths; newblockchain.get_logs_max_block_span). The tracked ref ingen-schema-keys.pyand the role README moves fromd3bc7da7to3ebf5f17.decdn_get_logs_max_block_span(#2152): the ceiling on one chain-watchereth_getLogsblock span. Empty means the daemon default of 10 000; when set it must be>= 1. It's wired the same way asdecdn_fee_shares_poll_interval_sec: defaults, template, the integer-shape and strictly-positive checks, README, the schema converge and the chart'sci-values.yaml. The docs follow the upstream runbook: set it only while range rejections keep rising, and use the lowest span reached, not the limit the provider quotes.range-min1case inmolecule/validationis the first negative test of the ">= 1when set" check. The key-count comment inmolecule/schema/verify.ymlnow matches the render (130 keys, slack 5).networks.ymlwas already current. The IPv6 bind (#2144) and the watchdog heartbeat (#2145) were already covered. The other upstream commits (CLI and client changes, tracing, thenode_idlog field, the new histograms) need no devops change.Upgrade note: a binary built without
3ebf5f17rejects the new key (deny_unknown_fields), so the role'sdecdn config validatestep fails the deploy. Leave the setting unset on older builds.Test plan
scripts/sync-monitoring.sh ../decdn origin/main --checkandscripts/sync-network-profiles.py ../decdn --checkreport currentmake lint,make lint-ansible,make lint-helmDECDN_CLI=<decdn built at 3ebf5f17> make lint-helm: real-binarydecdn config validateon all chart CI rendersmolecule test -s schemamolecule test -s validation(recordsrange-min1)make moleculein CI🤖 Generated with Claude Code