Skip to content

refactor(close): use wordmark-light.svg for brand mark #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yigitdot merged 3 commits into from
May 9, 2026
Merged

refactor(close): use wordmark-light.svg for brand mark #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f80f40
refactor(close): use wordmark-light.svg for brand mark
yigitdot May 9, 2026
bb1bb59
fix(a11y): drop decorative underscore from wordmark alt text
yigitdot May 9, 2026
93898d1
fix(close): set intrinsic dimensions on wordmark img to prevent CLS
yigitdot May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/site/Chrome.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ export function Chrome() {
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src="/wordmark-light.svg"
alt="decdn_"
alt="decdn"
width={112}
height={30}
className={onDark ? "hidden" : "block"}
/>
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src="/wordmark-dark.svg"
alt="decdn_"
alt="decdn"
width={112}
height={30}
className={onDark ? "block" : "hidden"}
Expand Down
23 changes: 14 additions & 9 deletions components/site/Close.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,21 @@ export function Close() {
Contact
</h2>

<div
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
data-reveal
className="hug flex items-baseline gap-2 font-semibold tracking-[-0.05em]"
style={{ fontSize: "var(--fs-display)", lineHeight: "0.86" }}
>
<span>decdn</span>
<span aria-hidden style={{ color: "var(--whisper)" }}>
_
</span>
</div>
src="/wordmark-light.svg"
alt="decdn"
width={411}
height={110}
className="block"
style={{
["--wordmark-h" as string]: "clamp(4.75rem, 14vw, 11.5rem)",
height: "var(--wordmark-h)",
width: "auto",
marginLeft: "calc(var(--wordmark-h) * -0.18)",
}}
Comment on lines +30 to +34

@gemini-code-assist gemini-code-assist Bot May 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Casting individual CSS variable keys with as string is a bit verbose. A cleaner approach in TypeScript is to cast the entire style object to React.CSSProperties, which allows for arbitrary property names starting with -- without needing individual casts for each key.

Suggested change
["--wordmark-h" as string]: "clamp(4.75rem, 14vw, 11.5rem)",
height: "var(--wordmark-h)",
width: "auto",
marginLeft: "calc(var(--wordmark-h) * -0.18)",
}}
"--wordmark-h": "clamp(4.75rem, 14vw, 11.5rem)",
height: "var(--wordmark-h)",
width: "auto",
marginLeft: "calc(var(--wordmark-h) * -0.18)",
} as React.CSSProperties}

@yigitdot yigitdot May 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — valid as a project-wide convention question, but not the right scope for this PR. The per-key ["--var" as string] cast is used 9× across 6 files today and there are zero as React.CSSProperties casts; switching this single site would create the codebase's first outlier (and the immediate neighbors in Close.tsx lines 39 and 49 still use the per-key form). Tracked for a sweep evaluation in #48.

/>
Comment thread
yigitdot marked this conversation as resolved.

{/* prettier-ignore */}
<p
Expand Down
Loading