Skip to content

chore: copy + types tidy (close #58, #59, #54) - #72

Merged
thiras merged 4 commits into
mainfrom
claude/quizzical-banzai-c3d46a
May 11, 2026
Merged

thiras merged 4 commits into
mainfrom
claude/quizzical-banzai-c3d46a

Conversation

@alpergundogdu

Copy link
Copy Markdown
Contributor

Summary

Three small unclaimed issues bundled into one PR. Each is mechanical, one commit each, no shared state between them beyond all three touching one or two top-level components.

  • Closes Remove AI-models FAQ item #58 — Remove the AI-models FAQ entry (last FaqItem in components/site/Faq.tsx). Preceding delay={320} item is now the trailing one; reveal cadence unchanged.
  • Closes Replace "run a node" CTA with "read the docs" #59 — Hero and Close CTAs read "read the docs →" pointing at links.docs (same-tab, matches the pre-existing run a node link behavior — target="_blank" deliberately not added). Orphaned runNode: entry removed from lib/links.ts (it was an identical string to docs and the two call sites were its only references).
  • Closes Drop --wordmark-h from CSSProperties augmentation; inline as local const #54 — --wordmark-h is consumed only inside the same JSX subtree that declared it (Close.tsx), so it's inlined as a local const wordmarkH. The entry is dropped from types/css.d.ts, narrowing the global CSSProperties augmentation back to --reveal-delay (the only token that genuinely bridges JSX → CSS rules in globals.css).

Test plan

  • pnpm lint — clean
  • pnpm exec prettier --check . — clean
  • pnpm exec tsc --noEmit — clean
  • pnpm build — static export succeeds; 10 pages prerendered
  • out/index.html checks:
    • grep "Does this work well for AI models" → 0
    • grep "run a node" → 0
    • 2 visible read the docs anchors pointing at https://docs.decdn.org/overview/introduction, no target="_blank"
    • No wordmark-h leakage anywhere under out/
  • Eyeball at pnpm dev:
    • FAQ shows 5 items, last is "Can publishers pay on behalf of users?"
    • Hero CTA cluster: read the litepaper → (new tab) · read the docs → (same tab) · source →
    • Close CTA cluster: same shape with the longer read the litepaper / read the docs / source on github
    • Close wordmark sizes identically to current production (size + negative margin unchanged)

Hero and Close CTAs read "read the docs →" pointing at links.docs
(docs.decdn.org/overview/introduction). The orphaned `runNode` entry in
lib/links.ts is removed; it was identical to `docs` and the two call
sites were its only references.

Closes #59
The --wordmark-h custom property was consumed only inside the same JSX
subtree that declared it — no CSS-side dependency — so a local `const`
in Close.tsx is enough. Removing the entry from types/css.d.ts narrows
the global CSSProperties augmentation back to --reveal-delay, which is
the only token that genuinely bridges JSX and globals.css.

Closes #54
Copilot AI review requested due to automatic review settings May 11, 2026 14:23
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 11, 2026 •

Copy link
Copy Markdown

Deploying website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93b75ba
Status: ✅  Deploy successful!
Preview URL: https://c4d487ef.website-70y.pages.dev
Branch Preview URL: https://claude-quizzical-banzai-c3d4.website-70y.pages.dev

View logs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bundles three small, mechanical cleanup tasks across the marketing site: removing an FAQ entry, updating CTA copy/links to point explicitly at docs, and narrowing the global CSSProperties type augmentation by inlining a one-off CSS custom property.

Changes:

  • Removed the AI-models FAQ item from Faq.tsx (FAQ now ends at the previous delay={320} item).
  • Replaced the “run a node” CTAs in Hero/Close with “read the docs”, and removed the now-unused links.runNode alias.
  • Inlined the Close wordmark height as a local constant and removed --wordmark-h from the global React CSSProperties augmentation.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types/css.d.ts Removes --wordmark-h from the global CSSProperties augmentation, leaving only --reveal-delay.
lib/links.ts Drops runNode since it was a duplicate of docs and is no longer referenced.
components/site/Hero.tsx Updates CTA label and link target to links.docs.
components/site/Faq.tsx Deletes the AI-models FAQ item per issue #58.
components/site/Close.tsx Inlines wordmark height via wordmarkH const and updates CTA to links.docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Close component by replacing the --wordmark-h CSS variable with a constant and updates several call-to-action links from 'run a node' to 'read the docs'. Additionally, it removes an AI-related FAQ item, cleans up the links configuration by removing the redundant runNode entry, and deletes the unused --wordmark-h type definition. I have no feedback to provide.

…ai-c3d46a

# Conflicts:
#	components/site/Faq.tsx
#	lib/links.ts
@alpergundogdu
alpergundogdu requested a review from thiras May 11, 2026 14:46
@thiras
thiras merged commit a5c7796 into main May 11, 2026
6 checks passed
@thiras
thiras deleted the claude/quizzical-banzai-c3d46a branch May 11, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace "run a node" CTA with "read the docs" Remove AI-models FAQ item Drop --wordmark-h from CSSProperties augmentation; inline as local const

3 participants