Repository navigation
chore: copy + types tidy (close #58, #59, #54) - #72
Conversation
Hero and Close CTAs read "read the docs →" pointing at links.docs (docs.decdn.org/overview/introduction). The orphaned `runNode` entry in lib/links.ts is removed; it was identical to `docs` and the two call sites were its only references. Closes #59
The --wordmark-h custom property was consumed only inside the same JSX subtree that declared it — no CSS-side dependency — so a local `const` in Close.tsx is enough. Removing the entry from types/css.d.ts narrows the global CSSProperties augmentation back to --reveal-delay, which is the only token that genuinely bridges JSX and globals.css. Closes #54
Deploying website with
|
| Latest commit: |
93b75ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4d487ef.website-70y.pages.dev |
| Branch Preview URL: | https://claude-quizzical-banzai-c3d4.website-70y.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR bundles three small, mechanical cleanup tasks across the marketing site: removing an FAQ entry, updating CTA copy/links to point explicitly at docs, and narrowing the global CSSProperties type augmentation by inlining a one-off CSS custom property.
Changes:
- Removed the AI-models FAQ item from
Faq.tsx(FAQ now ends at the previousdelay={320}item). - Replaced the “run a node” CTAs in Hero/Close with “read the docs”, and removed the now-unused
links.runNodealias. - Inlined the Close wordmark height as a local constant and removed
--wordmark-hfrom the global ReactCSSPropertiesaugmentation.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
types/css.d.ts |
Removes --wordmark-h from the global CSSProperties augmentation, leaving only --reveal-delay. |
lib/links.ts |
Drops runNode since it was a duplicate of docs and is no longer referenced. |
components/site/Hero.tsx |
Updates CTA label and link target to links.docs. |
components/site/Faq.tsx |
Deletes the AI-models FAQ item per issue #58. |
components/site/Close.tsx |
Inlines wordmark height via wordmarkH const and updates CTA to links.docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request refactors the Close component by replacing the --wordmark-h CSS variable with a constant and updates several call-to-action links from 'run a node' to 'read the docs'. Additionally, it removes an AI-related FAQ item, cleans up the links configuration by removing the redundant runNode entry, and deletes the unused --wordmark-h type definition. I have no feedback to provide.
…ai-c3d46a # Conflicts: # components/site/Faq.tsx # lib/links.ts
Summary
Three small unclaimed issues bundled into one PR. Each is mechanical, one commit each, no shared state between them beyond all three touching one or two top-level components.
FaqItemincomponents/site/Faq.tsx). Precedingdelay={320}item is now the trailing one; reveal cadence unchanged.links.docs(same-tab, matches the pre-existingrun a nodelink behavior —target="_blank"deliberately not added). OrphanedrunNode:entry removed fromlib/links.ts(it was an identical string todocsand the two call sites were its only references).--wordmark-hfrom CSSProperties augmentation; inline as local const #54 —--wordmark-his consumed only inside the same JSX subtree that declared it (Close.tsx), so it's inlined as a localconst wordmarkH. The entry is dropped fromtypes/css.d.ts, narrowing the globalCSSPropertiesaugmentation back to--reveal-delay(the only token that genuinely bridges JSX → CSS rules inglobals.css).Test plan
pnpm lint— cleanpnpm exec prettier --check .— cleanpnpm exec tsc --noEmit— cleanpnpm build— static export succeeds; 10 pages prerenderedout/index.htmlchecks:grep "Does this work well for AI models"→ 0grep "run a node"→ 0read the docsanchors pointing athttps://docs.decdn.org/overview/introduction, notarget="_blank"wordmark-hleakage anywhere underout/pnpm dev:read the litepaper →(new tab) ·read the docs →(same tab) ·source →read the litepaper/read the docs/source on github