Repository navigation
fix(nav): elevate the navbar when the drawer is open #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6a7e9c2
fix(nav): elevate the navbar when the drawer is open
yigitdot 0a29a6a
refactor(nav): apply review fixes for drawer-open elevation
yigitdot ececb0f
fix(mobile-menu): kill the jump-to-top on drawer close
yigitdot bbe1e5b
refactor(mobile-menu): apply review fixes for the scroll-restore path
yigitdot 82917df
style(mobile-menu): lowercase external labels and brand the footer
yigitdot 6670f0c
refactor(mobile-menu): apply review fixes from PR #89
yigitdot d86794b
style(mobile-menu): slow the section-anchor scroll to ~900ms ease-out…
yigitdot 3087113
style(mobile-menu): switch section-anchor scroll to linear at 600ms
yigitdot 50878bc
fix(mobile-menu): own the scroll-behavior swap inside scrollToAnchor
yigitdot c6936db
refactor(mobile-menu): apply PR #89 review fixes
yigitdot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
box-shadowtransition is added here, but it appears to be missing from theprefers-reduced-motionoverride for.chrome-nav(located later in the file around line 842). This will cause the shadow to snap instantly for users with reduced motion enabled, which contradicts the PR description's claim that shadow transitions 'complete cleanly'. Consider addingbox-shadow 360ms ...to that block to ensure a smooth fade-in for all users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0a29a6a — added
box-shadow 360msto the reduced-motion.chrome-navtransition list (alongsidebackground-color). The PR-description claim was wrong as written; the override at the bottom of the file was indeed gutting the shadow under reduced-motion.