feat: set fixed cache for active scenes and add all scenes getter#1829
Open
leanmendoza wants to merge 5 commits intomainfrom
Open
feat: set fixed cache for active scenes and add all scenes getter#1829leanmendoza wants to merge 5 commits intomainfrom
leanmendoza wants to merge 5 commits intomainfrom
Conversation
leanmendoza
changed the title
aleortega
reviewed
Dec 5, 2024
| return cache.get(entityId) || fixedCache.get(entityId) | ||
| }, | ||
| set(entityId: string, entity: Entity | NotActiveEntity) { | ||
| const isFixed = fixedCache.has(entityId) || (typeof entity !== 'string' && fixedTypes.includes(entity.type)) |
Contributor
There was a problem hiding this comment.
Ain't the second part of the condition enough to use the fixedCache? (I mean if entity type is SCENE we should already store it regardless if it is already stored there, right?)
|
|
||
| function getAllCachedScenes() { | ||
| return Array.from(fixedCache.values()).filter( | ||
| (entity): entity is Entity => typeof entity !== 'string' && entity.type === EntityType.SCENE |
Contributor
There was a problem hiding this comment.
I'm not familiar with this check, but can we prevent typeof entity !== string on setting time instead of retrieve time?
Author
There was a problem hiding this comment.
The LRU cache was already with this workaround for unsetting pointers with no longer active entities. I haven't had the intention of modifying this current behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a handler to retrieve all the cached scenes. Also, the scene entities are pre-cached at the start and unaffected by the LRU logic.