Set DID Resolution Result media type#244
Open
clehner wants to merge 1 commit intodecentralized-identity:masterfrom
Open
Set DID Resolution Result media type#244clehner wants to merge 1 commit intodecentralized-identity:masterfrom
clehner wants to merge 1 commit intodecentralized-identity:masterfrom
Conversation
peacekeeper
approved these changes
Jan 9, 2022
| koaResponse.body = ''; | ||
| } else { | ||
| koaResponse.set('Content-Type', 'application/ld+json;profile="https://w3id.org/did-resolution";charset=utf-8'); | ||
| // Stringify the result as otherwise the Content-Type gets overridden to |
Collaborator
There was a problem hiding this comment.
What if you reverse line 78 and 81? If works, it would be nicer to refactor setKoaResponse() to take in optional headers to set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the Content-Type header of the DID Resolution Result HTTP response to use the media type with profile parameter specified for a DID Resolution Result in DID Resolution:
application/ld+json;profile="https://w3id.org/did-resolution".Setting this Content-Type header helps DID resolver HTTP clients detect that the response is a DID Resolution Result - rather than e.g. a DID document alone, which is also allowed by DID Resolution's HTTP(S) Binding.