-
Notifications
You must be signed in to change notification settings - Fork 26
Create install.sh script
#119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@davidbeig can you check the qlty check blocking issues: https://qlty.sh/gh/decidim/projects/docker/pull/119/issues As we've talked, @microstudi will do the first round and @greenwoodt will check out the English messages and tone. Afterwards we'll check this out as @decidim/maintainers |
microstudi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one pain point when configuring the SMTP
Asked values are not explained, we should explain every parameter as most people won't undersand the meaning of each var:
so, instead of "SMTP_USERNAME", maybe somthing like:
SMTP Username (this is usually the email used to send emails)
Speacially confusing the difference between SMPT_ADRESS and SMTP_DOMAIN, we should explain the difference between these two!
I found another problem at the end of the script:


This PR closes #113 .
We are adding a script that enables the creation of a Decidim instance based on the docker images built in this repository. The user will be guided through some questions on how to properly configure the instance, and the script itself will take care of the necessary dependencies (such as the database, where the storage is going to be located, etc).
Some improvements:
This will generate extra-security on the download of the shell script and the files it uses, giving the final user more security.
What we still need
How to test
Since we still don't have the release zip, the way to test it is to zip ourselfs the script folder and push it to the server.
Later on, we need the deploy.zip to be under the
/tmp/decidim-docker-files/deploy.zip. It's a bit messy right now.Also, if you want to try it locally you can use
multipass