Skip to content

test: exclude power state checks from complex test #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eofff wants to merge 10 commits into
base: main
Choose a base branch
from
Open

test: exclude power state checks from complex test #1841

eofff wants to merge 10 commits into from
+361 −306

Conversation

@eofff
Copy link
Contributor

@eofff eofff commented Dec 19, 2025 •
edited
Loading

Description

Exclude power state checks from complex test. Write new e2e power state test.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: chore
summary: Exclude power state checks from complex test. Write new e2e power state test.
impact_level: low

@eofff eofff added this to the v1.4.0 milestone Dec 19, 2025
@eofff eofff marked this pull request as ready for review December 19, 2025 10:01
@eofff eofff requested review from Isteb4k and fl64 as code owners December 19, 2025 10:01
@eofff eofff force-pushed the test/power-state-check branch from 19e556f to 5435a88 Compare December 19, 2025 13:10
@eofff eofff requested a review from hardcoretime December 24, 2025 08:13
@eofff eofff force-pushed the test/power-state-check branch from 5435a88 to f37fa61 Compare December 24, 2025 08:20
hardcoretime
hardcoretime requested changes Dec 28, 2025
View reviewed changes
test/e2e/vm/power_state.go
Comment on lines +276 to +295
t.VMOPStop = vmopbuilder.New(
vmopbuilder.WithGenerateName("vmop-stop-"),
vmopbuilder.WithNamespace(t.VM.Namespace),
vmopbuilder.WithType(v1alpha2.VMOPTypeStop),
vmopbuilder.WithVirtualMachine(t.VM.Name),
)

t.VMOPStart = vmopbuilder.New(
vmopbuilder.WithGenerateName("vmop-start-"),
vmopbuilder.WithNamespace(t.VM.Namespace),
vmopbuilder.WithType(v1alpha2.VMOPTypeStart),
vmopbuilder.WithVirtualMachine(t.VM.Name),
)

t.VMOPRestart = vmopbuilder.New(
vmopbuilder.WithGenerateName("vmop-restart-"),
vmopbuilder.WithNamespace(t.VM.Namespace),
vmopbuilder.WithType(v1alpha2.VMOPTypeRestart),
vmopbuilder.WithVirtualMachine(t.VM.Name),
)
Copy link
Contributor

@hardcoretime hardcoretime Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use the functions from the util.go file?

Copy link
Contributor Author

@eofff eofff Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check vmop status.

@eofff eofff marked this pull request as draft December 30, 2025 08:54
Valeriy Khorunzhin added 2 commits January 12, 2026 14:35
add
b1a4297 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
fix
41b15fc 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the test/power-state-check branch from f37fa61 to 41b15fc Compare January 12, 2026 11:35
Valeriy Khorunzhin and others added 5 commits January 12, 2026 15:23
refactoring
5aec885 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff @hardcoretime
improve namespace suffix
e902adb 
Co-authored-by: Roman Sysoev <36233932+hardcoretime@users.noreply.github.com>
Signed-off-by: Valeriy Khorunzhin <b1kapb999@gmail.com>
fix prefixes
8fba428 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
do not wait agent
21951c2 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
fix alpine (check with alpine)
b6754a5 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff requested a review from hardcoretime January 12, 2026 15:18
@eofff eofff marked this pull request as ready for review January 12, 2026 15:18
fix
a2ad614 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the test/power-state-check branch from a097eb5 to 5e0bc37 Compare January 12, 2026 16:35
@eofff eofff marked this pull request as draft January 12, 2026 16:36
extend timeouts
dcaf210 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the test/power-state-check branch from 5e0bc37 to dcaf210 Compare January 12, 2026 17:37
@eofff eofff marked this pull request as ready for review January 12, 2026 17:39
@eofff eofff marked this pull request as draft January 12, 2026 17:48
do not use alpine
69dd477 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff marked this pull request as ready for review January 13, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@hardcoretime hardcoretime Awaiting requested review from hardcoretime

Requested changes must be addressed to merge this pull request.

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eofff @hardcoretime