HH3 migration#1
Open
TheRainbowPhoenix wants to merge 3 commits into
Open
Conversation
- Replaced Makefile with V3 version - Added V3 CI, devcontainer, and vscode configurations - Removed obsolete linker.ld and Dockerfile - Updated header extensions to .h in main.cpp - Updated main function signature - Removed obsolete calcInit() and calcEnd() - Updated input polling to use GetInput with non-blocking logic and new KEYCODE enums - Added 4-byte alignment to Input_Event - Fixed GitHub Actions versioning
- Fixed invalid conversion from int* to unsigned int* by creating unsigned variables for LCD_GetSize and assigning them to the int global variables. - Fixed properties accessed on event.data.key: used `keyCode` instead of `keycode`, and `direction == KEY_PRESSED` instead of `pressed`. - Added default case to switch statement for unhandled enum values.
- Moved `__attribute__((aligned(4)))` to the end of the variable declaration to avoid `-Werror=attributes` warning about it being applied to an elaborated type specifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to the new V3