Conversation
Owner
Author
|
The benchmark results are not super impressive and I'm seeing sizeable regressions in areas of the code that I thought would be unrelated. Even for the specific benchmark that should be sped up ( |
declanvk
force-pushed
the
bulk-load
branch
2 times, most recently
from
bde066f to
728ee8b
Compare
**Description** - Add a bulk insert operation that can take a list of key-value pairs and create a tree structure by recursively bucketing them based on key bytes - Add helper functions for creating portions of the tree with uninitialized key-value pairs in the leafs, and being able to later initialized them. - Update several `TreeMap` APIs to use the bulk insert method. **Motivation** My hope is that the bulk insert operation will be more effecient when compared to a "one at a time" insert strategy. Initial benchmarking says that it may need some additional work. **Testing Done** `./scripts/full-test.sh nightly` and ran fuzzer for 1 hour. Added unit tests too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_offfuzz action, update docs and safety condition