Related Products loader :: remove throw new error and add unavailable items #102
Open
Steffany-Martins wants to merge 2 commits intodeco-sites:mainfrom
Open
Related Products loader :: remove throw new error and add unavailable items #102Steffany-Martins wants to merge 2 commits intodeco-sites:mainfrom
Steffany-Martins wants to merge 2 commits intodeco-sites:mainfrom
Conversation
|
|
||
| if (!productId) { | ||
| throw new Error("Missing props. Please fill: slug or id"); | ||
| // throw new Error("Missing props. Please fill: slug or id"); |
Contributor
There was a problem hiding this comment.
Suggested change
| // throw new Error("Missing props. Please fill: slug or id"); |
Contributor
igorbrasileiro
left a comment
igorbrasileiro
left a comment
There was a problem hiding this comment.
Thank you for contributing!
Remove the commented code that I pointed above, and it will be OK.
Contributor
|
@tlgimenes take a look here. |
Author
|
@tlgimenes guys, can realease this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When utilizing the loader ''vtexLegacyRelatedProductsLoader.ts'', the program currently returns the error message "Missing props. Please fill: slug or id." if the product ID does not exist.
Proposed Fixes: