Skip to content

Fix Linx Impulse Loader (similarItems)#164

Open
gustavo-vasconcellos wants to merge 7 commits intomainfrom
fix/linx-impulse-similar-id
Open

Fix Linx Impulse Loader (similarItems)#164
gustavo-vasconcellos wants to merge 7 commits intomainfrom
fix/linx-impulse-similar-id

Conversation

@gustavo-vasconcellos
Copy link
Collaborator

@gustavo-vasconcellos gustavo-vasconcellos commented Jul 26, 2023

  • Add extract ID from param function
  • Fix method to get shelfs
  • Remove position props and search on each position property (top, middle, bottom)

Admin to test: https://deco.cx/admin/sites/xpto/blocks/Product%20Page
Branch: fix/linx

image

@tlgimenes
Copy link
Contributor

I didn't really get it. Can't we just use other paths/slugs so we don't need to regex it?

@gustavo-vasconcellos gustavo-vasconcellos changed the title fix(similarItems): add regex logic and remove slug from props Fix Linx Impulse Loader (similarItems) Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants