chore: layer_norm cleanup similar to the one for constant_norm_rescale#698
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the runtime activation layer-norm output path in the SAE implementation, adding attribute deletion after applying stored normalization parameters.
Changes:
- Replace direct return expression with an in-place assignment then return
- Delete
self.ln_muandself.ln_stdinsiderun_time_activation_ln_outafter first use
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+352
to
+355
| x = x * self.ln_std + self.ln_mu # type: ignore | ||
| del self.ln_mu | ||
| del self.ln_std | ||
| return x |
chanind
reviewed
Jun 9, 2026
chanind
left a comment
chanind
left a comment
Collaborator
There was a problem hiding this comment.
This looks reasonable, but could we add a test on this as well so we don't regress?
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
You have tested formatting, typing and tests
make check-cito check format and linting. (you can runmake formatto format code if needed.)