Skip to content

Run linter in local dev, not just CI. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dajohi merged 1 commit into from
Dec 4, 2025
Merged

Run linter in local dev, not just CI. #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ISC License

Copyright (c) 2015-2023, The Decred developers
Copyright (c) 2015-2025, The Decred developers
Copyright (c) 2017, Jonathan Chappelow

Permission to use, copy, modify, and/or distribute this software for any
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ information about consensus rule voting.

## Developing

It is recommended to use Go 1.17 (or newer) for development.
It is recommended to use Go 1.24 (or newer) for development.

To build the code:

Expand Down
3 changes: 3 additions & 0 deletions lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

golangci-lint run
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2017-2023 The Decred developers
// Copyright (c) 2017-2025 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

Expand Down Expand Up @@ -57,7 +57,7 @@ var (
"changesubsidysplit": "Change PoW/PoS Subsidy Split",
"changesubsidysplitr2": "Change PoW/PoS Subsidy Split To 1/89",
"blake3pow": "Change PoW to BLAKE3 and ASERT",
"maxtreasuryspend": "Change maximum treasury expenditure policy",
"maxtreasuryspend": "Change Maximum Treasury Expenditure Policy",
}
longAgendaDescriptions = map[string]string{
"sdiffalgorithm": "Specifies a proposed replacement algorithm for determining the stake difficulty (commonly called the ticket price). This proposal resolves all issues with a new algorithm that adheres to the referenced ideals.",
Expand Down
16 changes: 6 additions & 10 deletions run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
#!/bin/bash
# The script does automatic checking on a Go package and its sub-packages, including:
# 1. gofmt (http://golang.org/cmd/gofmt/)
# 2. golint (https://github.com/golang/lint)
# 3. go vet (http://golang.org/cmd/vet)
# 4. gosimple (https://github.com/dominikh/go-simple)
# 5. unconvert (https://github.com/mdempsky/unconvert)
# 6. ineffassign (https://github.com/gordonklaus/ineffassign)
# 7. race detector (http://blog.golang.org/race-detector)
# 8. test coverage (http://blog.golang.org/cover)
#!/usr/bin/env bash

set -ex

# run tests
env GORACE="halt_on_error=1" go test -race ./...

# run linters when not running as a GitHub action
[ -z "$GITHUB_ACTIONS" ] && source ./lint.sh

echo "------------------------------------------"
echo "Tests completed successfully!"
Loading