This repository was archived by the owner on Aug 1, 2019. It is now read-only.
Bugfix/verify_required_parameters#10
Open
jack1902 wants to merge 2 commits intodeep-security:masterfrom
jack1902:bugfix/verify_required_parameters
Open
Bugfix/verify_required_parameters#10jack1902 wants to merge 2 commits intodeep-security:masterfrom jack1902:bugfix/verify_required_parameters
jack1902 wants to merge 2 commits intodeep-security:masterfrom
jack1902:bugfix/verify_required_parameters
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrected verify_required_parameters so that it checks for all properties correctly, if a single property is missing, then it returns false immediately to log out the message from this if/else block: