Remember the flash Wi-Fi credentials for the Bigme F7 form too - #33
Merged
Conversation
…7 too The ESP32 flash form already pre-filled its Wi-Fi fields from the last flash, but the Bigme F7 bootstrap form did not — so every F7 meant retyping an SSID and password that are the same for every screen on the network. The persist step that /flash/start ran inline is now a single _remember_flash_wifi() helper called by both flash routes, and the F7 form pre-fills from the same remembered credentials as the ESP32 one. The F7 firmware has no fallback network, so its route passes None for the second SSID/password and leaves a remembered fallback untouched instead of clearing it. A bootstrap with the Wi-Fi fields left blank (flash only, no provisioning) persists nothing. The F7 console tokenizer cannot take whitespace, so the F7 fields only pre-fill when the remembered values are space-free — otherwise the form would helpfully fill in a value it then rejects on submit. Tests: the F7 route persists and leaves the fallback alone, a blank bootstrap keeps what was remembered, and the ESP32 route still persists all four fields (a regression guard on the extracted helper).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESP32 Flash a screen form already pre-filled its Wi-Fi fields from the last flash; the Bigme F7 bootstrap form did not — so every F7 meant retyping an SSID and password that are the same for every screen on the network.
What changed
/flash/startran inline is now a single_remember_flash_wifi()helper, called by both flash routes./flash/start_f7persists what it provisioned. The F7 firmware has no fallback network, so it passesNonefor the second SSID/password and leaves a remembered fallback untouched rather than clearing it. A bootstrap with the Wi-Fi fields blank (flash only, no provisioning) persists nothing.Tests
Three new: the F7 route persists and leaves the fallback alone, a blank F7 bootstrap keeps what was remembered, and the ESP32 route still persists all four fields (a regression guard on the extracted helper). Full suite 804 passed / 5 skipped; ruff + pyright clean.
🤖 Generated with Claude Code