Skip to content

test: harden process and TUI synchronization #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dejay-vu merged 2 commits into from
Jul 14, 2026
Merged

test: harden process and TUI synchronization #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5d8f4
test: harden process exit checks
dejay-vu Jul 14, 2026
6f4bccb
test(tui): wait for GC confirmation callback
dejay-vu Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/tui/test_pilot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ async def test_gc_previews_before_deleting(self, ctx, remote_root):
await pilot.press("2")
await _wait_for(lambda: isinstance(app.screen, EnvsScreen))
await pilot.press("g")
await _wait_for(lambda: isinstance(app.screen, ConfirmModal))
await pilot.pause()
assert isinstance(app.screen, ConfirmModal)
app.screen.query_one("#yes")
Expand Down
7 changes: 6 additions & 1 deletion tests/unit/test_env_executors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,17 @@ def _prepare(


def _wait_for_process_exit(pid: int, *, timeout: float = 5.0) -> None:
if pid <= 0:
pytest.fail(f"invalid process ID: {pid}")

deadline = time.monotonic() + timeout
while time.monotonic() < deadline:
try:
os.kill(pid, 0)
except OSError:
except ProcessLookupError:
return
except OSError as exc:
pytest.fail(f"unable to inspect background process {pid}: {exc}")
time.sleep(0.05)
pytest.fail(f"background process {pid} did not exit within {timeout:.1f}s")

Expand Down