Submission of the 2nd assignment of madevos and lfdversluis #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up dead code and fixed a nullpointer bug Refactored the Revision functions to a separate RevisionManager class added javadoc to the revision manager and created the checkoutmanager class rolled back the checkoutmanager. Also improved the method complexities added tests for the RevisionManager class Refactored eu.squooss.service.abstractmetric There are no cyclic dependencies between the packages in eu.squooss.service anymore. Moved AlitheiaPlugin, AlreadyProcessingException, MetricMismatchException and Result to eu.squooss.impl.service.metricactivator. Also written tests for the AbstractMetric class. Fixed an mistake where I put the refactored files in the wrong package (should be eu.squooss.service.metricsactivator instead of eu.squooss.impl.service.metricsactivator). one test fails refactored duplicate code refactored duplicate code refactored duplicate code refactored duplicate code refactored duplicate code Updated the RevisionManagerTest Also removed the logs. Breaked dependencies Between eu.squooss.service and eu.squooss.impl.service (see report for details). fixed the failing test changed setup to beforeclass diabled two tests removed the two tests dramatic improvement of test coverage removed unused imports Improved the test suite Fixed naming of test packages Removed logs removed TODOs from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hereby the submission of the 2nd assignment of the Software Reengineering course.