Skip to content

Add smtp_port support to settings module - #261

Open
mangopep wants to merge 1 commit into
dell:mainfrom
mangopep:feature-257-smtp-port
Open

mangopep wants to merge 1 commit into
dell:mainfrom
mangopep:feature-257-smtp-port

Conversation

@mangopep

Copy link
Copy Markdown

Description

Adds support for configuring smtp_port in the dellemc.powerscale.settings module. The change adds the new module parameter, includes it in the email settings update payload, and updates documentation, sample playbook, mocks, and unit tests.

GitHub Issue #
Fixes #257

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Ran targeted unit tests for the settings module:
    ANSIBLE_COLLECTIONS_PATH=/private/tmp PYTHONPATH=/private/tmp \
    /Users/Desktop/ansible-powerscale/.venv/bin/python -m pytest \
    tests/unit/plugins/modules/test_settings.py -v
Screenshot 2026-06-01 at 1 16 46 AM

Signed-off-by: Savitha-1111 <savitham.sse23@rvce.edu.in>
@mangopep
mangopep requested a review from trisha-dell as a code owner May 31, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: support for setting smtp_port in dellemc.powerscale.settings

2 participants