Implementation for ldap provider group - #275
Merged
Merged
Conversation
… with check/diff mode - Add three new optional LDAP parameters: group_base_dn (str, <=255), provider_domain (str, <=255), authentication (bool) - Wire all three into create/update with non-destructive semantics: None (omitted) preserves server value, explicit "" clears string fields, explicit False is transmitted for authentication - Byte-exact comparison (no case/whitespace normalisation) - Length validation rejects before API write - Set supports_check_mode=True; guard all write calls behind if not self.module.check_mode - Implement diff mode with before/after restricted to declared, differing parameters; no diff key when mode is off - Explicitly exclude bind_password from all diff payloads - Add attributes: block declaring full check_mode/diff_mode support - Remove "check mode is not supported" note - Add 35 new unit tests covering all FRs, check/diff mode, bind_password redaction, idempotency, and non-destructive semantics - 1531/1531 collection-wide unit tests pass (--forked) Story: Story-74951-ansible-powerscale-expanded-ldap-configuration-part1 AC: AC-001, AC-002-R, AC-003, AC-004, AC-005 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Story: Story-74951-ansible-powerscale-expanded-ldap-configuration-part1 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…pdate copyright - Relocated group_base_dn, provider_domain, authentication documentation from top-level options to ldap_parameters.suboptions to match the argument spec in get_ldap_parameters() - Updated copyright year from 2021-2024 to 2021-2026 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…authentication - Full descriptions with constraints (<=255 chars), clearing/omission semantics - Disambiguate group_base_dn vs base_dn; provider_domain vs user_domain/group_domain - Document authentication: false as identity-only provider (Req-SEC-C-3) - Add troubleshooting notes for invalid DN syntax and domain-qualification errors Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
EXAMPLES: - Separate group search hierarchy (group_base_dn distinct from base_dn) - Identity-only provider (authentication: false) - Multi-domain qualification (provider_domain) - Check-mode + diff preview with register/debug Playbook (playbooks/modules/ldap.yml): - Configure/clear group_base_dn, set/clear provider_domain - Disable/re-enable authentication with idempotency re-run - Check-mode + diff demonstration with register/debug - All pre-existing tasks preserved unchanged Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- Changelog fragment with minor_changes for documentation expansion, examples, playbook coverage, and troubleshooting notes - Release note fragment documenting check_mode/diff_mode behavior change Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
The test relied on class-level get_ldap_args retaining server_uris and base_dn from its initial definition. However, prior test scenarios (test_create Scenario 3/5) mutate the shared dict, clearing base_dn and server_uris. When test_create_throws_exception runs afterward, the create() method fails at parameter validation (base_dn is mandatory) before reaching the API call where ApiException would be raised. Fix: explicitly set server_uris, server_uri_state, and base_dn so the code path reaches the mocked create_providers_ldap_item call. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
MangirishK
approved these changes
Sep 11, 2026
sapana05
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an enhancement for ldap provider group modules
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration