Additional_Packages defect fix#4042
Merged
abhishek-sa1 merged 4 commits intodell:pub/q1_devfrom Feb 25, 2026
Merged
Conversation
Kratika-P
approved these changes
Feb 25, 2026
Collaborator
|
@sakshi-singla-1735 can you update PR description |
| ], | ||
| "aarch64": [ | ||
| "additional_packages", | ||
| "slurm_control_node", "slurm_node", "login_node", "login_compiler_node" |
Collaborator
There was a problem hiding this comment.
there is no subgroup called additional packages. its only in softwares section
Collaborator
Author
There was a problem hiding this comment.
removed
abhishek-sa1
approved these changes
Feb 25, 2026
abhishek-sa1
added a commit
that referenced
this pull request
Feb 25, 2026
* Update omnia.sh * cleanup of files under offline_repo dir during pulp cleanup Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * removing doca-ofed from nfs share Signed-off-by: Katakam-Rakesh <katakam.rakesh@dell.com> * Upgrade of input credential files to 2.1 * Added new package type rpm_repo Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * input config changes Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * Fixed ansible lint issues * fixed lint issues * Fixed ansible lint issues * fixed ansible lint issues * offline build-image and discovery updates (#3956) * Use Pulp-hosted builder images for x86_64 builds * added x86_64 image-builder image * Update default_packages.json Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Refine image build prereqs and regctl handling * Update omnia_metadata_file path to use variable Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Airgap: move telemetry/NFS prep offline and package installs to prepare_oim * added nolog true * Update prepare_oim_completion.yml Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Update aarch64_prereq.yml Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Update main.yml Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Update main.yml Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Update main.yml Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Replace command with podman_image module for image tasks Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Replace Podman command with Ansible module Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Align podman image pull with retries and tagging for x86_64 and aarch64 * Fix podman tagging for x86_64 and aarch64 images --------- Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Added flow if any munge key update, will be useful if munge key changes * lint issue fix * Update main.yml for copyright Signed-off-by: Katakam Rakesh Naga Sai <125246792+Katakam-Rakesh@users.noreply.github.com> * centralize oim_metadata.yml path and remove static backup_location variable * Update omnia.sh * updating /etc/hosts entries * Update service_k8s.json Signed-off-by: Katakam Rakesh Naga Sai <125246792+Katakam-Rakesh@users.noreply.github.com> * lint issue fixed * Add user registry to crio.conf Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * duplicated hostnames * Update omnia.sh * resolve input validation + lint Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * Removed slurmd dependency issue where ssh key changes on slurmctld, live * Added user guidance messages in rollback_omnia.yml and upgrade_cluster.yml * Fix for local repo is failing as cuda run package download issue Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * Modification of Rollback guidance message * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Addition of user guidance messages for cluster reprovisioning and rollback after upgrade to 2.1 (#3978) * Added user guidance messages in rollback_omnia.yml and upgrade_cluster.yml * Modification of Rollback guidance message * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * fix status return in execute command Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * Initial iDRAC Telemetry Node addition and deletion changes (#3972) * Initial set of changes for iDRAC Telemetry add and remove node * Ansible link and pylint fixes * Ansible lint fixes * Updated Copyrights to 2026 * Addressed the comments * support multiple Omnia versions (2.1.0.0, 2.1.0.1) using a single core container tag (2.1) (#3983) * LDMS Slurm node add /delete (#3976) * LDMS slurm node add/delete * pr review comments update * Node drain logic for deletion * mask docker credentials in local_repo logs Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * Shell instead of command for piping * lint fixes * Removing the IP's from the Activated IP list (#3992) * Fix for local_repo.yml allows passes even with invalid package names in JSON files. Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * checkmarx fixes Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * Updated permission for slurmdbd Added new force_conf option for allowing confs pass through validation * removede new file * Lock Mechanism added for Upgrade Sequence Integrity * Renamed force_conf to skip_merge * Update omnia.sh * auto-backup of slurm-confs * upgrade utility added to oim_cleanup and credential utility * Lock Mechanism for Upgrade Sequence Integrity (#3994) * Slurm delete node - drain node before delete - skip_merge new option (#3986) * Node drain logic for deletion * Shell instead of command for piping * lint fixes * Updated permission for slurmdbd Added new force_conf option for allowing confs pass through validation * removede new file * Renamed force_conf to skip_merge * checkmarx fixes - II Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * fix for security issue - improper resource shutdown issue Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * mapping file update * To configure per-repository sync and caching policies in localrepo Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * SSH pemission and access issue fix for upgrade after prepare_oim * ansible lint fix Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * Update validate_ssh_permissions.yml * updated validate_ssh_permissions.yml * Update validate_ssh_permissions.yml * ARM nodes gpu detection * Update omnia.sh * SSH pemission and access issue fix for upgrade after prepare_oim (#4019) * updating pulp_cleanup and timeout for tarball and iso Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> * Input validation fix for duplicate admin IP in pxe mapping file * Handled delete scenarios along with /etc/hosts * Delete node removal of service and NFS data * Fix admin dynamic_range subnet validation and remove flawed netmask check (#4010) * fix input validation for high_availability_config.yml Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * updating copyrights Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> * Updating Reprovision guidance, update success msg and rollback flow * Update main.yml * Update main.yml * Additional_Packages defect fix (#4042) * additional packages defect * reverse check * parent key check * removing the additional_package group --------- Signed-off-by: pullan1 <sudha.pullalaravu@dell.com> Signed-off-by: Katakam-Rakesh <katakam.rakesh@dell.com> Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> Signed-off-by: Katakam Rakesh Naga Sai <125246792+Katakam-Rakesh@users.noreply.github.com> Signed-off-by: Vrinda_Marwah <vrinda.marwah@dell.com> Signed-off-by: Jagadeesh N V <39791839+jagadeeshnv@users.noreply.github.com> Co-authored-by: SOWJANYAJAGADISH123 <Sowjanya.Jagadish@dell.com> Co-authored-by: pullan1 <sudha.pullalaravu@dell.com> Co-authored-by: Katakam-Rakesh <katakam.rakesh@dell.com> Co-authored-by: Katakam Rakesh Naga Sai <125246792+Katakam-Rakesh@users.noreply.github.com> Co-authored-by: mithileshreddy04 <mithilesh.reddy@dell.com> Co-authored-by: balajikumaran.cs <balajikumaran.cs@dellteam.com> Co-authored-by: Abhishek S A <abhishek.sa3@dell.com> Co-authored-by: snarthan <narthan.s@dell.com> Co-authored-by: Nagachandan-P <Nagachandan.p@dell.com> Co-authored-by: Vrinda_Marwah <vrinda.marwah@dell.com> Co-authored-by: Nethravathi M G <146437298+nethramg@users.noreply.github.com> Co-authored-by: sakshi-singla-1735 <sakshi.s@dell.com> Co-authored-by: priti-parate <140157516+priti-parate@users.noreply.github.com> Co-authored-by: Nethra mg <g_nethravathi@dell.com> Co-authored-by: balajikumaran.cs <balajikumaran.c.s@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix arch-specific validation for additional_packages
Added ADDITIONAL_PACKAGES_SUPPORTED_SUBGROUPS dict in config.py (x86_64 supports slurm + k8s groups, aarch64 supports slurm only)
Error if additional_packages parent key missing from arch JSON
Error if arch JSON has unsupported subgroups for that architecture
Error if arch JSON has subgroups not declared in software_config.json
Skip validation for subgroups not supported on the current arch instead of failing
Files changed: config.py, common_validation.py, local_repo_validation.py