Skip to content

feat: export create table sql in DAT write specs - #63

Merged
rliao147 merged 2 commits into
mainfrom
stack/dat-create-table-sql
Oct 9, 2026
Merged

rliao147 merged 2 commits into
mainfrom
stack/dat-create-table-sql

Conversation

@rliao147

@rliao147 rliao147 commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Description

SQL harnesses currently reconstruct CREATE TABLE statements from the corpus schema. Export an optional createSql template using the same SQL the generator executes, with {{table}} as the destination placeholder. Retain structured fields for DAT harnesses that don't use SQL.

How was this patch tested?

  1. Serde and validator suites pass on Scala 2.12 and 2.13.
  2. Verify supplied SQL executes and target binding preserves literals.
  3. Verify partitioned nested writes and legacy corpus fallback.
  4. Existing insert_multiple corpus-generation case passes.

Does this require an update to the documentation?

No

@rliao147
rliao147 requested a review from OussamaSaoudi October 9, 2026 20:47
@rliao147
rliao147 marked this pull request as ready for review October 9, 2026 20:47

@OussamaSaoudi OussamaSaoudi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment.

@rliao147
rliao147 merged commit 481097d into main Oct 9, 2026
1 check passed
@rliao147
rliao147 deleted the stack/dat-create-table-sql branch October 9, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants