Sync sysml2-modeling documentation with Agents upstream changes - #23
Merged
Conversation
Remove render asTreeDiagram from view examples and update the render kind example in the Critical distinction paragraph to asInterconnectionDiagram. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates DictionaryMark’s SysML2 modeling guidance and model views to clarify that expose controls diagram scope while render only affects diagram style, and then simplifies the actual view definitions accordingly.
Changes:
- Clarified the modeling standard to distinguish
expose(scope) vsrender(style), and updated the example style reference toasInterconnectionDiagram. - Removed explicit
render asTreeDiagram;statements from all view usages in the SysML2 design views file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docs/sysml2/views/design-views.sysml |
Simplifies view usages by removing explicit render asTreeDiagram; lines while preserving expose scoping. |
.github/standards/sysml2-modeling.md |
Updates the standard to explicitly document expose vs render responsibilities and aligns examples with the new guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way SysML2 views are rendered in both the design documentation and the SysML2 model files. The main change is the removal of explicit
render asTreeDiagram;statements from all view definitions, clarifying that the rendering style is not necessary for scoping diagram content and should not be confused with theexposedirective.Documentation and modeling standards update:
.github/standards/sysml2-modeling.mdto clarify the distinction betweenexpose(which defines diagram scope) andrender(which only affects diagram style), and changed the example rendering style fromasTreeDiagramtoasInterconnectionDiagram.SysML2 model simplification:
render asTreeDiagram;lines from thedocs/sysml2/views/design-views.sysmlfile, simplifying the view definitions and aligning them with clarified documentation standards.