Skip to content

Fix/reclassify fileassert shared package - #60

Merged
Malcolmnixon merged 4 commits into
mainfrom
fix/reclassify-fileassert-shared-package
Jun 22, 2026
Merged

Fix/reclassify fileassert shared package#60
Malcolmnixon merged 4 commits into
mainfrom
fix/reclassify-fileassert-shared-package

Conversation

@Malcolmnixon

Copy link
Copy Markdown
Member

This pull request refactors the documentation and requirements to reclassify FileAssert from an OTS (Off-The-Shelf) item to a Shared Package. It updates the structure and content of design, requirements, verification documents, and review configuration to reflect this new classification. The documentation is reorganized to clearly distinguish between OTS items and shared packages, and all references, evidence, and review paths are updated accordingly.

Reclassification and Documentation Structure Updates:

  • FileAssert is now documented as a Shared Package instead of an OTS item, with new sections and files (docs/design/shared.md, docs/design/shared/fileassert.md, docs/verification/shared.md, docs/verification/shared/fileassert.md). All references in requirements, design, and verification documents are updated to reflect this change. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

  • The requirements YAML for FileAssert is moved and rewritten to docs/reqstream/shared/fileassert.yaml, with requirement and test IDs updated to use the "Shared" prefix.

  • The review configuration in .reviewmark.yaml is updated to point to the new shared package paths and review IDs.

Input File and Reference Updates:

  • Input file lists for design and verification documents are updated to reference the new shared package files and remove the old OTS FileAssert files. [1] [2] [3] [4]

Tooling Update:

  • The version of the demaconsulting.fileassert tool in .config/dotnet-tools.json is updated from 0.4.0 to 0.5.1.

Malcolm Nixon and others added 4 commits June 22, 2026 09:23
FileAssert cannot treat its own published package as an OTS item. Per the
software-items standard, a package produced by the same program consumed in
CI is a Shared Package. Additionally, the self-validation test names
FileAssert_Exists and FileAssert_Contains no longer exist; they were renamed
to FileAssert_File and FileAssert_Text when validation was refactored into
per-assertion-type files.

Changes:
- Move docs/reqstream/ots/fileassert.yaml to docs/reqstream/shared/
- Rename requirement ID from FileAssert-OTS-FileAssert to
  FileAssert-Shared-FileAssert with tag [shared]
- Replace FileAssert_Exists and FileAssert_Contains with FileAssert_File,
  FileAssert_Text, FileAssert_Html, and FileAssert_Pdf to cover the assertion
  types actually used by this project
- Move design and verification docs from ots/ to shared/ folders
- Add shared.md overview documents for design and verification sections
- Update docs/design/ots.md to remove FileAssert and add clarifying note
- Update docs/verification/ots.md to remove FileAssert references
- Update both definition.yaml files for correct document assembly
- Update docs/design/introduction.md to document Shared Package artifacts
- Update .reviewmark.yaml review set from FileAssert-OTS-FileAssert to
  FileAssert-Shared-FileAssert with corrected paths
- Update requirements.yaml include path

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 22, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Malcolmnixon
Malcolmnixon merged commit 5c46fba into main Jun 22, 2026
15 of 17 checks passed
@Malcolmnixon
Malcolmnixon deleted the fix/reclassify-fileassert-shared-package branch June 22, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants