Skip to content

Agent updates next - #95

Merged
Malcolmnixon merged 7 commits into
mainfrom
agent-updates-next
Apr 29, 2026
Merged

Agent updates next#95
Malcolmnixon merged 7 commits into
mainfrom
agent-updates-next

Conversation

@Malcolmnixon

Copy link
Copy Markdown
Member

Pull Request

Description

Numerous agent updates and improvements to the repository.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Closes #

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: pwsh ./lint.ps1 (cross-platform)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Copilot AI review requested due to automatic review settings April 29, 2026 13:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes documentation build outputs into generated/ folders and updates CI/lint/standards to treat those artifacts as build outputs that should not be edited or linted.

Changes:

  • Update Pandoc definition.yaml files to consume generated report sections from */generated/ paths.
  • Update the build-docs GitHub Actions workflow and .fileassert.yaml to write and validate HTML/PDF/report artifacts in the new generated/ locations (with final PDFs in docs/generated/).
  • Update agent guidance and linter/spellcheck configs to exclude generated/ output folders; simplify .gitignore rules accordingly.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
docs/requirements_report/definition.yaml Switch trace matrix input to generated output path.
docs/requirements_doc/definition.yaml Switch requirements/justifications inputs to generated output paths.
docs/code_review_report/definition.yaml Switch review report input to generated output path.
docs/code_review_plan/definition.yaml Switch review plan input to generated output path.
docs/code_quality/definition.yaml Switch CodeQL/Sonar report inputs to generated output paths.
docs/build_notes/definition.yaml Switch build notes + tool versions inputs to generated output paths.
AGENTS.md Add “no generated file access” rule for agents.
.yamllint.yaml Attempt to ignore generated outputs from yamllint.
.markdownlint-cli2.yaml Ignore **/generated/** for markdownlint.
.gitignore Replace specific doc output ignores with a blanket **/generated/ ignore.
.github/workflows/build.yaml Write doc artifacts into generated/ folders and upload from docs/generated/*.
.github/standards/technical-documentation.md Update documentation structure guidance and generated-file rules.
.github/standards/requirements-principles.md Clarify “unit name vs internal construction” guidance.
.github/standards/design-documentation.md Add references guidance and ban markdown hyperlinks for cross-refs.
.github/agents/lint-fix.agent.md Add guidance for handling wide markdown tables under MD013.
.fileassert.yaml Update expected artifact paths to new generated locations.
.cspell.yaml Ignore **/generated/** for spellchecking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
Comment thread .yamllint.yaml Outdated
@Malcolmnixon

Copy link
Copy Markdown
Member Author

@copilot apply changes based on the comments in this thread

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/build_notes/definition.yaml Outdated
Comment thread .github/workflows/build.yaml Outdated
@Malcolmnixon

Copy link
Copy Markdown
Member Author

@copilot apply changes based on the comments in this thread

…rated/ for artifacts

Agent-Logs-Url: https://github.com/demaconsulting/TemplateDotNetLibrary/sessions/6085cad4-0084-4249-9a4a-e0dac8b7a61e

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/standards/technical-documentation.md
Comment thread .github/standards/design-documentation.md Outdated
@Malcolmnixon

Copy link
Copy Markdown
Member Author

@copilot apply changes based on the comments in this thread

Copilot AI commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@copilot apply changes based on the comments in this thread

Both changes applied in b4617e8:

  • technical-documentation.md: {section}.md now described as "zero or more" (optional)
  • design-documentation.md: References section guidance now explicitly points to introduction.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yaml
Comment thread .github/workflows/build.yaml
@Malcolmnixon

Copy link
Copy Markdown
Member Author

@copilot apply changes based on the comments in this thread

Copilot AI commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@copilot apply changes based on the comments in this thread

Done in 3fe871a — both reviewmark-usage.md and reqstream-usage.md now reference the generated/ subfolders for all tool output paths.

@Malcolmnixon
Malcolmnixon merged commit 81cfe93 into main Apr 29, 2026
6 checks passed
@Malcolmnixon
Malcolmnixon deleted the agent-updates-next branch April 29, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants