Fix hydration mismatch in SSR client components#8
Merged
Conversation
Resolves hydration errors where aria-controls IDs differ between server and client rendering. The issue occurred because renderToReadableStream() was called without the identifierPrefix option, causing React's internal ID counters to generate different IDs on server vs client. This particularly affected Radix UI components (Dialog, Popover, etc.) that rely on React's useId() hook. The fix adds identifierPrefix: '' to renderToReadableStream options, ensuring consistent ID generation across server rendering and client hydration. Affected file: packages/bunbox/src/core/ssr.tsx:469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves hydration errors where aria-controls IDs differ between server and client rendering.
The issue occurred because renderToReadableStream() was called without the identifierPrefix option, causing React's internal ID counters to generate different IDs on server vs client. This particularly affected Radix UI components (Dialog, Popover, etc.) that rely on React's useId() hook.
The fix adds identifierPrefix: '' to renderToReadableStream options, ensuring consistent ID generation across server rendering and client hydration.
Affected file: packages/bunbox/src/core/ssr.tsx:469