Replace detector ensemble with real pYIN + cepstrum fusion - #14
Open
denizyesilirmak wants to merge 1 commit into
Open
Replace detector ensemble with real pYIN + cepstrum fusion#14denizyesilirmak wants to merge 1 commit into
denizyesilirmak wants to merge 1 commit into
Conversation
denizyesilirmak
commented
Jul 25, 2026
Owner
- Remove YinPitchDetector entirely; pYIN is now the sole time-domain detector
- Rewrite PyinPitchDetector as real frame-wise pYIN (Mauch & Dixon 2014): Beta(2,18) threshold prior, per-candidate probability mass over all CMND minima, deepest-minimum fallback, and a light pitch-continuity bonus in place of the paper's HMM stage
- Replace EnsembleSelector voting with DetectorFusion: pYIN is the precise primary, cepstrum a coarse corroborator; frequencies are never averaged and mismatched confidence scales are never compared (agree/clash/solo rules)
- Fix cepstrum returning confident junk on pure tones: pick only strict local maxima (no range-boundary envelope tail) and use scale-invariant peak-vs-rival prominence instead of the saturating snr/5 confidence
- Drop unused IPitchDetector::setThreshold; rename cryptic variables (diff_/cmnd_ → squaredDifference_/normalizedDifference_, etc.)
- Rebuild tests around the new architecture (fusion decision tests with stub detectors, harmonic-tone cepstrum test); note tests were silently passing in Release builds with asserts compiled out
- Remove YinPitchDetector entirely; pYIN is now the sole time-domain detector - Rewrite PyinPitchDetector as real frame-wise pYIN (Mauch & Dixon 2014): Beta(2,18) threshold prior, per-candidate probability mass over all CMND minima, deepest-minimum fallback, and a light pitch-continuity bonus in place of the paper's HMM stage - Replace EnsembleSelector voting with DetectorFusion: pYIN is the precise primary, cepstrum a coarse corroborator; frequencies are never averaged and mismatched confidence scales are never compared (agree/clash/solo rules) - Fix cepstrum returning confident junk on pure tones: pick only strict local maxima (no range-boundary envelope tail) and use scale-invariant peak-vs-rival prominence instead of the saturating snr/5 confidence - Drop unused IPitchDetector::setThreshold; rename cryptic variables (diff_/cmnd_ → squaredDifference_/normalizedDifference_, etc.) - Rebuild tests around the new architecture (fusion decision tests with stub detectors, harmonic-tone cepstrum test); note tests were silently passing in Release builds with asserts compiled out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.