README: fix DI version, credit BASS and GeneralUser GS - #26
Merged
Merged
Conversation
….0.0 Bumped in the multi-tab work (see the CI-fix commit pinning it there) to avoid a cross-TFM assembly-version conflict between the net472 app and the net8.0 test project; the README's Dependencies list still said 8.0.1.
ManagedBass was listed, but that's just the .NET wrapper -- the actual third-party dependency it binds to is the native BASS/BASSMIDI/BASSVST libraries bundled in JianpuEditor/Native/, with their own non-commercial licensing restriction (already noted in NOTICE.md and the Requirements section, but not called out where the rest of this project's dependencies are listed). Also added GeneralUser GS, the bundled SoundFont, alongside the other bundled third-party assets (basic-pitch, GAME) already credited here.
denmase
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small doc fixes to the README's Dependencies list — no code changes.
Microsoft.Extensions.DependencyInjectionstill said 8.0.1; the multi-tab work (PR #24) bumped it to 9.0.0 to avoid a cross-TFM assembly-version conflict between the net472 app project and the net8.0 test project.ManagedBasswas listed, but that's just the .NET wrapper — the actual third-party dependency it binds to is the native BASS/BASSMIDI/BASSVST libraries bundled inJianpuEditor/Native/, with their own non-commercial licensing restriction (already noted inNOTICE.mdand the Requirements section, but not called out where the rest of this project's dependencies are listed). Also added GeneralUser GS, the bundled SoundFont, alongside the other bundled third-party assets (basic-pitch, GAME) already credited in that section.Test plan
JianpuEditor/JianpuEditor.csprojtoday.JianpuEditor/Native/NOTICE.mdandJianpuEditor/Resources/Soundfonts/LICENSE.txt.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pguj4XSScE141p1ScWoqEr
Generated by Claude Code