Skip to content

Fix CA1707 test-naming warnings and GitHub Actions Node 20 deprecation #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denmase merged 1 commit into from
Sep 18, 2026
+13 −11
Merged

Fix CA1707 test-naming warnings and GitHub Actions Node 20 deprecation #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ dotnet_diagnostic.CA1305.severity = none
dotnet_diagnostic.CA1822.severity = suggestion
dotnet_diagnostic.CA1859.severity = suggestion

[JianpuEditor.Tests/**/*.cs]
# xUnit test naming and inline test data arrays
[JianpuEditor.Tests/{*.cs,**/*.cs}]
# xUnit test naming and inline test data arrays. Note: "**/*.cs" alone only matches files in a
# subdirectory (an EditorConfig glob quirk) -- it silently skipped every *.cs file directly under
# JianpuEditor.Tests/ (e.g. MainFormMultiTabTests.cs), which is why CA1707 kept firing for those.
dotnet_diagnostic.CA1707.severity = none
dotnet_diagnostic.CA1861.severity = none
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup .NET SDK
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v6
with:
dotnet-version: 8.0.x
cache: true
Expand All @@ -26,7 +26,7 @@ jobs:
**/*.csproj

- name: Cache .NET build outputs
uses: actions/cache@v4
uses: actions/cache@v6
with:
path: |
JianpuEditor/obj
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
run: ./scripts/test-midi-export.ps1

- name: Upload Release build
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: JianpuEditor-${{ github.sha }}
path: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Resolve version
id: version
Expand All @@ -47,7 +47,7 @@ jobs:
Set-Content -Path $iss -Value $content -NoNewline

- name: Setup .NET SDK
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v6
with:
dotnet-version: 8.0.x
cache: true
Expand All @@ -56,7 +56,7 @@ jobs:
**/*.csproj

- name: Cache .NET build outputs
uses: actions/cache@v4
uses: actions/cache@v6
with:
path: |
JianpuEditor/obj
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
Write-Host "Portable package: $zip ($([math]::Round((Get-Item $zip).Length / 1MB, 2)) MB)"

- name: Upload installer artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: JianpuEditor-Setup-${{ steps.version.outputs.value }}
path: |
Expand All @@ -135,7 +135,7 @@ jobs:
retention-days: 90

- name: Upload portable artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: JianpuEditor-Portable-${{ steps.version.outputs.value }}
path: ${{ steps.portable.outputs.zip }}
Expand Down