Add Segno and Coda navigation markers - #36
Merged
Merged
Conversation
Wires up OrnamentType.Segno/Coda through the same ribbon/Edit-menu/ context-menu/glyph pattern as Staccato/Accent/Tenuto -- both values already existed in the enum with zero code referencing them. Unlike those, these are visual-only with no ApplyArticulation-style playback change, since actually performing a D.S./D.C. jump needs real changes to ScoreMidiSchedule's linear-pass scheduling (documented in ROADMAP.md as a separate, higher-risk follow-up). Deliberately left OrnamentType.RepeatStart/RepeatEnd unwired: a repeat bar line is a property of the measure boundary itself (a thick double bar with dots spanning the staff height), not a note-anchored point symbol the way Segno/Coda genuinely are in real notation, so reusing the ornament-band mechanism for those two would model the wrong thing. ROADMAP.md now documents this distinction so it isn't reintroduced later; they stay dead until the planned BarLineType field lands. Verified via the same sandbox pipeline as every prior change this session: dotnet build succeeds against the real project/package graph, dotnet format --verify-no-changes passes on both projects, and new xUnit tests cover the glyph mapping and a render-to-bitmap smoke test in both compact and default layout modes. dotnet test itself cannot execute in this sandbox; real confirmation comes from GitHub Actions CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pguj4XSScE141p1ScWoqEr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuing the Indonesian notasi angka gap list (
ROADMAP.md), the note/beat-anchored half ofphase 7 (repeat bar lines / volta brackets / D.C.-D.S.-Coda-Segno navigation).
OrnamentType.Segno/Codathrough the same ribbon + Edit-menu + context-menu +glyph pattern as Staccato/Accent/Tenuto -- both values already existed in the enum with zero
code referencing them. Visual-only: no playback/MIDI-export change, since actually performing a
D.S./D.C. jump needs real changes to
ScoreMidiSchedule's linear-pass scheduling (documented inROADMAP.mdas its own, higher-risk follow-up, not attempted here).OrnamentType.RepeatStart/RepeatEndunwired. A repeat bar line is aproperty of the measure boundary itself (a thick double bar with dots spanning the staff
height), not a note-anchored point symbol the way Segno/Coda genuinely are in real notation --
reusing the ornament-band mechanism for those two would model the wrong thing. Documented this
distinction in
ROADMAP.mdso it isn't reintroduced later; they stay dead until the originallyplanned
BarLineTypefield lands as its own piece of work.Test plan
Verified via the same sandbox pipeline as every prior change this session:
dotnet buildsucceeds against the real project/package graph (0 errors/warnings).dotnet format --verify-no-changespasses on both projects.default layout modes.
Not verified in this sandbox: the new glyphs' actual on-screen appearance hasn't been visually
confirmed on a real Windows machine, same caveat as every prior UI change this session.
dotnet testitself cannot execute here (no WindowsDesktop runtime pack); real confirmation of the newtests comes from GitHub Actions CI.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Pguj4XSScE141p1ScWoqEr
Generated by Claude Code