fix(ci): call changeset directly in release workflow - #5
Merged
Conversation
`pnpm version` ran pnpm's built-in version command (printed Node versions), not `changeset version`, so nothing bumped and the release PR came up empty. Use `pnpm changeset version` / `pnpm changeset publish` in changesets/action, and drop the misleading `version`/`changeset` package scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow failed on the first run:
changesets/action'sversion: pnpm versioninvoked pnpm's built-inversioncommand (which just printed Node/pnpm versions) instead ofchangeset version. Nothing bumped, so the release branch had no commits and the "Version Packages" PR errored with No commits between main and changeset-release/main.Fix: call changeset directly in the action —
version: pnpm changeset version/publish: pnpm changeset publish— and drop the misleadingversion/changesetpackage scripts (theversionscript never ran anyway;pnpm versionis built in).After merge, the Release workflow will open a proper "Version Packages" PR from the pending
Initial releasechangeset (0.0.0 → 0.1.0).Test plan